2014-12-10 13:57:08

by Anjana Sasindran

Subject: [PATCH] staging: rts5208: Removed the new typedefs

This patch fix the checkpatch.pl warning:

WARNING: do not add new typedefs

Signed-off-by: Anjana Sasindran <[email protected]>
---
drivers/staging/rts5208/rtsx_sys.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rts5208/rtsx_sys.h b/drivers/staging/rts5208/rtsx_sys.h
index 0b6b4d4..f04d997 100644
--- a/drivers/staging/rts5208/rtsx_sys.h
+++ b/drivers/staging/rts5208/rtsx_sys.h
@@ -28,7 +28,7 @@
#include "rtsx_chip.h"
#include "rtsx_card.h"

-typedef dma_addr_t ULONG_PTR;
+dma_addr_t ULONG_PTR;

static inline void rtsx_exclusive_enter_ss(struct rtsx_chip *chip)
{
--
1.9.1

2014-12-10 14:20:07

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: rts5208: Removed the new typedefs

On Wed, Dec 10, 2014 at 07:24:16PM +0530, Anjana Sasindran wrote:
> This patch fix the checkpatch.pl warning:
>
> WARNING: do not add new typedefs
>
> Signed-off-by: Anjana Sasindran <[email protected]>
> ---
> drivers/staging/rts5208/rtsx_sys.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rts5208/rtsx_sys.h b/drivers/staging/rts5208/rtsx_sys.h
> index 0b6b4d4..f04d997 100644
> --- a/drivers/staging/rts5208/rtsx_sys.h
> +++ b/drivers/staging/rts5208/rtsx_sys.h
> @@ -28,7 +28,7 @@
> #include "rtsx_chip.h"
> #include "rtsx_card.h"
>
> -typedef dma_addr_t ULONG_PTR;
> +dma_addr_t ULONG_PTR;
>
> static inline void rtsx_exclusive_enter_ss(struct rtsx_chip *chip)
> {

Please learn how the C language works before attempting to contribute to
the Linux kernel. You obviously didn't even test build this code, which
means you are trying to waste my time, a very rude thing to do to
someone else, don't you think?

*plonk*