2014-12-10 17:37:40

by Anjana Sasindran

Subject: [PATCH] drivers: cpuidle: Added a blank line after declarations

This patch fix the checkpatch.pl warning:

WARNING: Missing blank line after declarations

Signed-off-by: Anjana Sasindran <[email protected]>
---
drivers/cpuidle/driver.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/cpuidle/driver.c b/drivers/cpuidle/driver.c
index e431d11..7fa66f6 100644
--- a/drivers/cpuidle/driver.c
+++ b/drivers/cpuidle/driver.c
@@ -144,6 +144,7 @@ static inline void __cpuidle_unset_driver(struct cpuidle_driver *drv)
static void cpuidle_setup_broadcast_timer(void *arg)
{
int cpu = smp_processor_id();
+
clockevents_notify((long)(arg), &cpu);
}

--
1.9.1

2014-12-10 21:24:25

by Rafael J. Wysocki

Subject: Re: [PATCH] drivers: cpuidle: Added a blank line after declarations

On Wednesday, December 10, 2014 11:07:24 PM Anjana Sasindran wrote:
> This patch fix the checkpatch.pl warning:
>
> WARNING: Missing blank line after declarations

Please send a patch to checkpatch.pl maintainers to make it not complain in
this case instead. Thanks!

> Signed-off-by: Anjana Sasindran <[email protected]>
> ---
> drivers/cpuidle/driver.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpuidle/driver.c b/drivers/cpuidle/driver.c
> index e431d11..7fa66f6 100644
> --- a/drivers/cpuidle/driver.c
> +++ b/drivers/cpuidle/driver.c
> @@ -144,6 +144,7 @@ static inline void __cpuidle_unset_driver(struct cpuidle_driver *drv)
> static void cpuidle_setup_broadcast_timer(void *arg)
> {
> int cpu = smp_processor_id();
> +
> clockevents_notify((long)(arg), &cpu);
> }
>
>

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

2014-12-10 21:44:54

by Joe Perches

Subject: Re: [PATCH] drivers: cpuidle: Added a blank line after declarations

On Wed, 2014-12-10 at 22:45 +0100, Rafael J. Wysocki wrote:
> On Wednesday, December 10, 2014 11:07:24 PM Anjana Sasindran wrote:
> > This patch fix the checkpatch.pl warning:
> >
> > WARNING: Missing blank line after declarations
>
> Please send a patch to checkpatch.pl maintainers to make it not complain in
> this case instead. Thanks!

Direct any plaints to Andrew Morton and Greg KH instead.
I don't care one way or another.

https://lkml.org/lkml/2014/3/6/550
https://lkml.org/lkml/2014/3/10/457