2014-12-16 10:21:59

by Ivan T. Ivanov

[permalink] [raw]
Subject: [PATCH] spi: qup: Add SPI_CPOL configuration support

Device support SPI_CPOL, but driver have missed to add
support for this configuration.

Signed-off-by: Ivan T. Ivanov <[email protected]>
---
drivers/spi/spi-qup.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c
index 390ed71..1c3329c 100644
--- a/drivers/spi/spi-qup.c
+++ b/drivers/spi/spi-qup.c
@@ -337,7 +337,7 @@ static irqreturn_t spi_qup_qup_irq(int irq, void *dev_id)
static int spi_qup_io_config(struct spi_device *spi, struct spi_transfer *xfer)
{
struct spi_qup *controller = spi_master_get_devdata(spi->master);
- u32 config, iomode, mode;
+ u32 config, iomode, mode, control;
int ret, n_words, w_size;

if (spi->mode & SPI_LOOP && xfer->len > controller->in_fifo_sz) {
@@ -392,6 +392,15 @@ static int spi_qup_io_config(struct spi_device *spi, struct spi_transfer *xfer)

writel_relaxed(iomode, controller->base + QUP_IO_M_MODES);

+ control = readl_relaxed(controller->base + SPI_IO_CONTROL);
+
+ if (spi->mode & SPI_CPOL)
+ control |= SPI_IO_C_CLK_IDLE_HIGH;
+ else
+ control &= ~SPI_IO_C_CLK_IDLE_HIGH;
+
+ writel_relaxed(control, controller->base + SPI_IO_CONTROL);
+
config = readl_relaxed(controller->base + SPI_CONFIG);

if (spi->mode & SPI_LOOP)
--
1.9.1


2014-12-29 17:14:47

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] spi: qup: Add SPI_CPOL configuration support

On Tue, Dec 16, 2014 at 12:21:55PM +0200, Ivan T. Ivanov wrote:
> Device support SPI_CPOL, but driver have missed to add
> support for this configuration.

Applied, thanks.


Attachments:
(No filename) (173.00 B)
signature.asc (473.00 B)
Digital signature
Download all attachments