2014-12-22 18:36:43

by Fabian Frédérick

Subject: [PATCH 1/1 net-next] netfilter: remove unnecessary sizeof(char)

sizeof(char) is always 1.

Suggested-by: Joe Perches <[email protected]>
Signed-off-by: Fabian Frederick <[email protected]>
---
net/netfilter/nf_log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netfilter/nf_log.c b/net/netfilter/nf_log.c
index 43c926c..1191f66 100644
--- a/net/netfilter/nf_log.c
+++ b/net/netfilter/nf_log.c
@@ -426,7 +426,7 @@ static int netfilter_log_sysctl_init(struct net *net)
nf_log_sysctl_fnames[i];
nf_log_sysctl_table[i].data = NULL;
nf_log_sysctl_table[i].maxlen =
- NFLOGGER_NAME_LEN * sizeof(char);
+ NFLOGGER_NAME_LEN;
nf_log_sysctl_table[i].mode = 0644;
nf_log_sysctl_table[i].proc_handler =
nf_log_proc_dostring;
--
1.9.1

2014-12-23 13:31:17

by Pablo Neira Ayuso

Subject: Re: [PATCH 1/1 net-next] netfilter: remove unnecessary sizeof(char)

On Mon, Dec 22, 2014 at 07:36:15PM +0100, Fabian Frederick wrote:
> sizeof(char) is always 1.

Applied, thanks.

Made a small change on it:

> Suggested-by: Joe Perches <[email protected]>
> Signed-off-by: Fabian Frederick <[email protected]>
> ---
> net/netfilter/nf_log.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/nf_log.c b/net/netfilter/nf_log.c
> index 43c926c..1191f66 100644
> --- a/net/netfilter/nf_log.c
> +++ b/net/netfilter/nf_log.c
> @@ -426,7 +426,7 @@ static int netfilter_log_sysctl_init(struct net *net)
> nf_log_sysctl_fnames[i];
> nf_log_sysctl_table[i].data = NULL;
> nf_log_sysctl_table[i].maxlen =
> - NFLOGGER_NAME_LEN * sizeof(char);
> + NFLOGGER_NAME_LEN;

this now fits in one line (80-chars).

> nf_log_sysctl_table[i].mode = 0644;
> nf_log_sysctl_table[i].proc_handler =
> nf_log_proc_dostring;
> --
> 1.9.1
>