2014-12-22 20:25:54

by Jim Davis

Subject: [PATCH] media: tlg2300: disable building the driver

This driver doesn't build with the current kernel, as reported in
linux-next (https://lkml.org/lkml/2014/12/18/483) and by the 0-day
build system
(https://www.mail-archive.com/[email protected]/msg83501.html).
Since it's scheduled for removal, disable building it for now.

Signed-off-by: Jim Davis <[email protected]>
---
drivers/staging/media/tlg2300/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/media/tlg2300/Kconfig b/drivers/staging/media/tlg2300/Kconfig
index 81784c6f7b88..87181b0f77fd 100644
--- a/drivers/staging/media/tlg2300/Kconfig
+++ b/drivers/staging/media/tlg2300/Kconfig
@@ -7,6 +7,7 @@ config VIDEO_TLG2300
select VIDEOBUF_VMALLOC
select SND_PCM
select VIDEOBUF_DVB
+ depends on BROKEN

---help---
This is a video4linux driver for Telegent tlg2300 based TV cards.
--
2.1.1

2014-12-23 17:02:44

by Mauro Carvalho Chehab

Subject: Re: [PATCH] media: tlg2300: disable building the driver

Em Mon, 22 Dec 2014 13:25:45 -0700
Jim Davis <[email protected]> escreveu:

> This driver doesn't build with the current kernel, as reported in
> linux-next (https://lkml.org/lkml/2014/12/18/483) and by the 0-day
> build system
> (https://www.mail-archive.com/[email protected]/msg83501.html).
> Since it's scheduled for removal, disable building it for now.
>
> Signed-off-by: Jim Davis <[email protected]>
> ---
> drivers/staging/media/tlg2300/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/tlg2300/Kconfig b/drivers/staging/media/tlg2300/Kconfig
> index 81784c6f7b88..87181b0f77fd 100644
> --- a/drivers/staging/media/tlg2300/Kconfig
> +++ b/drivers/staging/media/tlg2300/Kconfig
> @@ -7,6 +7,7 @@ config VIDEO_TLG2300
> select VIDEOBUF_VMALLOC
> select SND_PCM
> select VIDEOBUF_DVB
> + depends on BROKEN

Actually, what it was missing on the original driver were to preserve
the original dependency. In this case, it should be dependent of
MEDIA_USB_SUPPORT.

>
> ---help---
> This is a video4linux driver for Telegent tlg2300 based TV cards.


--

Cheers,
Mauro