2014-12-25 09:43:25

by Fabian Frédérick

Subject: [PATCH 1/1 linux-next] fs/reiserfs/inode.c: replace 0 by NULL for pointers

Fix sparse warning:
fs/reiserfs/inode.c:2769:19: warning: Using plain integer as NULL pointer

Cc: [email protected]
Cc: Jeff Mahoney <[email protected]>
Cc: Andrew Morton <[email protected]>
Signed-off-by: Fabian Frederick <[email protected]>
---
fs/reiserfs/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c
index a7eec98..e72401e 100644
--- a/fs/reiserfs/inode.c
+++ b/fs/reiserfs/inode.c
@@ -2766,7 +2766,7 @@ static int reiserfs_write_begin(struct file *file,
int old_ref = 0;

inode = mapping->host;
- *fsdata = 0;
+ *fsdata = NULL;
if (flags & AOP_FLAG_CONT_EXPAND &&
(pos & (inode->i_sb->s_blocksize - 1)) == 0) {
pos ++;
--
1.9.1

2014-12-25 12:18:03

by Richard Weinberger

Subject: Re: [PATCH 1/1 linux-next] fs/reiserfs/inode.c: replace 0 by NULL for pointers

On Thu, Dec 25, 2014 at 10:43 AM, Fabian Frederick <[email protected]> wrote:
> Fix sparse warning:
> fs/reiserfs/inode.c:2769:19: warning: Using plain integer as NULL pointer

I see such fixes often and I always wonder whether this is still an
issue with modern compilers/computers.
Can you point out a problem which will be fixed by your patch?

> Cc: [email protected]
> Cc: Jeff Mahoney <[email protected]>
> Cc: Andrew Morton <[email protected]>
> Signed-off-by: Fabian Frederick <[email protected]>
> ---
> fs/reiserfs/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c
> index a7eec98..e72401e 100644
> --- a/fs/reiserfs/inode.c
> +++ b/fs/reiserfs/inode.c
> @@ -2766,7 +2766,7 @@ static int reiserfs_write_begin(struct file *file,
> int old_ref = 0;
>
> inode = mapping->host;
> - *fsdata = 0;
> + *fsdata = NULL;
> if (flags & AOP_FLAG_CONT_EXPAND &&
> (pos & (inode->i_sb->s_blocksize - 1)) == 0) {
> pos ++;
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/



--
Thanks,
//richard