2014-12-29 10:21:07

by Fabian Frédérick

Subject: [PATCH 1/1 RESEND] ptrace: remove linux/compat.h inclusion under CONFIG_COMPAT

Commit 84c751bd4aeb
("ptrace: add ability to retrieve signals without removing from a queue (v4)")
includes <linux/compat.h> globally in ptrace.c

This patch removes inclusion under if defined CONFIG_COMPAT.

Signed-off-by: Fabian Frederick <[email protected]>
---
kernel/ptrace.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/kernel/ptrace.c b/kernel/ptrace.c
index 1eb9d90..227fec3 100644
--- a/kernel/ptrace.c
+++ b/kernel/ptrace.c
@@ -1077,7 +1077,6 @@ int generic_ptrace_pokedata(struct task_struct *tsk, unsigned long addr,
}

#if defined CONFIG_COMPAT
-#include <linux/compat.h>

int compat_ptrace_request(struct task_struct *child, compat_long_t request,
compat_ulong_t addr, compat_ulong_t data)
--
2.1.0

2014-12-29 13:17:27

by Oleg Nesterov

Subject: Re: [PATCH 1/1 RESEND] ptrace: remove linux/compat.h inclusion under CONFIG_COMPAT

On 12/29, Fabian Frederick wrote:
> Commit 84c751bd4aeb
> ("ptrace: add ability to retrieve signals without removing from a queue (v4)")
> includes <linux/compat.h> globally in ptrace.c
>
> This patch removes inclusion under if defined CONFIG_COMPAT.
>
> Signed-off-by: Fabian Frederick <[email protected]>

Acked-by: Oleg Nesterov <[email protected]>



> ---
> kernel/ptrace.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/ptrace.c b/kernel/ptrace.c
> index 1eb9d90..227fec3 100644
> --- a/kernel/ptrace.c
> +++ b/kernel/ptrace.c
> @@ -1077,7 +1077,6 @@ int generic_ptrace_pokedata(struct task_struct *tsk, unsigned long addr,
> }
>
> #if defined CONFIG_COMPAT
> -#include <linux/compat.h>
>
> int compat_ptrace_request(struct task_struct *child, compat_long_t request,
> compat_ulong_t addr, compat_ulong_t data)
> --
> 2.1.0
>