2014-12-29 14:30:08

by Fabian Frédérick

[permalink] [raw]
Subject: [PATCH 00/11 linux-next] drivers: remove unnecessary version.h inclusion

This small patchset removes unnecessary version.h includes detected by
versioncheck in drivers branch.

Fabian Frederick (11):
rsxx: remove unnecessary version.h inclusion
skd: remove unnecessary version.h inclusion
ipmi: remove unnecessary version.h inclusion
input: remove unnecessary version.h inclusion
[media] tw68: remove unnecessary version.h inclusion
[media] s5p-g2d: remove unnecessary version.h inclusion
[media] s5p-mfc: remove unnecessary version.h inclusion
[media] vivid: remove unnecessary version.h inclusion
[media] uvcvideo: remove unnecessary version.h inclusion
GenWQE: remove unnecessary version.h inclusion
s390/hmcdrv: remove unnecessary version.h inclusion

drivers/block/rsxx/rsxx_priv.h | 1 -
drivers/block/skd_main.c | 1 -
drivers/char/ipmi/ipmi_ssif.c | 1 -
drivers/input/touchscreen/elants_i2c.c | 2 --
drivers/media/pci/tw68/tw68.h | 1 -
drivers/media/platform/s5p-g2d/g2d.c | 1 -
drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 1 -
drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 1 -
drivers/media/platform/vivid/vivid-tpg.h | 1 -
drivers/media/usb/uvc/uvc_v4l2.c | 1 -
drivers/misc/genwqe/card_base.h | 1 -
drivers/misc/genwqe/card_sysfs.c | 1 -
drivers/s390/char/hmcdrv_mod.c | 1 -
13 files changed, 14 deletions(-)

--
2.1.0


2014-12-29 14:30:31

by Fabian Frédérick

[permalink] [raw]
Subject: [PATCH 01/11 linux-next] rsxx: remove unnecessary version.h inclusion

Based on versioncheck.

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/block/rsxx/rsxx_priv.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/block/rsxx/rsxx_priv.h b/drivers/block/rsxx/rsxx_priv.h
index 6bbc64d..21adc25 100644
--- a/drivers/block/rsxx/rsxx_priv.h
+++ b/drivers/block/rsxx/rsxx_priv.h
@@ -25,7 +25,6 @@
#ifndef __RSXX_PRIV_H__
#define __RSXX_PRIV_H__

-#include <linux/version.h>
#include <linux/semaphore.h>

#include <linux/fs.h>
--
2.1.0

2014-12-29 14:30:33

by Fabian Frédérick

[permalink] [raw]
Subject: [PATCH 02/11 linux-next] skd: remove unnecessary version.h inclusion

Based on versioncheck.

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/block/skd_main.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index 1e46eb2..542353a 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -34,7 +34,6 @@
#include <linux/dma-mapping.h>
#include <linux/completion.h>
#include <linux/scatterlist.h>
-#include <linux/version.h>
#include <linux/err.h>
#include <linux/scatterlist.h>
#include <linux/aer.h>
--
2.1.0

2014-12-29 14:31:22

by Fabian Frédérick

[permalink] [raw]
Subject: [PATCH 03/11 linux-next] ipmi: remove unnecessary version.h inclusion

Based on versioncheck.

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/char/ipmi/ipmi_ssif.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
index fd5a5e8..120ed8d 100644
--- a/drivers/char/ipmi/ipmi_ssif.c
+++ b/drivers/char/ipmi/ipmi_ssif.c
@@ -31,7 +31,6 @@
* interface into the I2C driver, I believe.
*/

-#include <linux/version.h>
#if defined(MODVERSIONS)
#include <linux/modversions.h>
#endif
--
2.1.0

2014-12-29 14:31:20

by Fabian Frédérick

[permalink] [raw]
Subject: [PATCH 05/11 linux-next] [media] tw68: remove unnecessary version.h inclusion

Based on versioncheck.

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/media/pci/tw68/tw68.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/media/pci/tw68/tw68.h b/drivers/media/pci/tw68/tw68.h
index 7a7501b..93f2335 100644
--- a/drivers/media/pci/tw68/tw68.h
+++ b/drivers/media/pci/tw68/tw68.h
@@ -25,7 +25,6 @@
* GNU General Public License for more details.
*/

-#include <linux/version.h>
#include <linux/pci.h>
#include <linux/videodev2.h>
#include <linux/notifier.h>
--
2.1.0

2014-12-29 14:31:18

by Fabian Frédérick

[permalink] [raw]
Subject: [PATCH 04/11 linux-next] input: remove unnecessary version.h inclusion

Based on versioncheck.

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/input/touchscreen/elants_i2c.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
index a510f7e..926c58e 100644
--- a/drivers/input/touchscreen/elants_i2c.c
+++ b/drivers/input/touchscreen/elants_i2c.c
@@ -33,10 +33,8 @@
#include <linux/delay.h>
#include <linux/uaccess.h>
#include <linux/buffer_head.h>
-#include <linux/version.h>
#include <linux/slab.h>
#include <linux/firmware.h>
-#include <linux/version.h>
#include <linux/input/mt.h>
#include <linux/acpi.h>
#include <linux/of.h>
--
2.1.0

2014-12-29 14:31:15

by Fabian Frédérick

[permalink] [raw]
Subject: [PATCH 07/11 linux-next] [media] s5p-mfc: remove unnecessary version.h inclusion

Based on versioncheck.

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 1 -
drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 1 -
2 files changed, 2 deletions(-)

diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
index c6c3452..a9ef843 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
@@ -18,7 +18,6 @@
#include <linux/platform_device.h>
#include <linux/sched.h>
#include <linux/slab.h>
-#include <linux/version.h>
#include <linux/videodev2.h>
#include <linux/workqueue.h>
#include <media/v4l2-ctrls.h>
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
index bd64f1d..68df3cd 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
@@ -19,7 +19,6 @@
#include <linux/module.h>
#include <linux/platform_device.h>
#include <linux/sched.h>
-#include <linux/version.h>
#include <linux/videodev2.h>
#include <media/v4l2-event.h>
#include <linux/workqueue.h>
--
2.1.0

2014-12-29 14:31:13

by Fabian Frédérick

[permalink] [raw]
Subject: [PATCH 08/11 linux-next] [media] vivid: remove unnecessary version.h inclusion

Based on versioncheck.

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/media/platform/vivid/vivid-tpg.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/media/platform/vivid/vivid-tpg.h b/drivers/media/platform/vivid/vivid-tpg.h
index 9dc463a4..bd8b1c7 100644
--- a/drivers/media/platform/vivid/vivid-tpg.h
+++ b/drivers/media/platform/vivid/vivid-tpg.h
@@ -20,7 +20,6 @@
#ifndef _VIVID_TPG_H_
#define _VIVID_TPG_H_

-#include <linux/version.h>
#include <linux/types.h>
#include <linux/errno.h>
#include <linux/random.h>
--
2.1.0

2014-12-29 14:32:22

by Fabian Frédérick

[permalink] [raw]
Subject: [PATCH 09/11 linux-next] [media] uvcvideo: remove unnecessary version.h inclusion

Based on versioncheck.

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/media/usb/uvc/uvc_v4l2.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v4l2.c
index 9c5cbcf..43e953f 100644
--- a/drivers/media/usb/uvc/uvc_v4l2.c
+++ b/drivers/media/usb/uvc/uvc_v4l2.c
@@ -13,7 +13,6 @@

#include <linux/compat.h>
#include <linux/kernel.h>
-#include <linux/version.h>
#include <linux/list.h>
#include <linux/module.h>
#include <linux/slab.h>
--
2.1.0

2014-12-29 14:32:42

by Fabian Frédérick

[permalink] [raw]
Subject: [PATCH 06/11 linux-next] [media] s5p-g2d: remove unnecessary version.h inclusion

Based on versioncheck.

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/media/platform/s5p-g2d/g2d.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/media/platform/s5p-g2d/g2d.c b/drivers/media/platform/s5p-g2d/g2d.c
index 47ba8fb..ec3e124 100644
--- a/drivers/media/platform/s5p-g2d/g2d.c
+++ b/drivers/media/platform/s5p-g2d/g2d.c
@@ -12,7 +12,6 @@

#include <linux/module.h>
#include <linux/fs.h>
-#include <linux/version.h>
#include <linux/timer.h>
#include <linux/sched.h>
#include <linux/slab.h>
--
2.1.0

2014-12-29 14:33:16

by Fabian Frédérick

[permalink] [raw]
Subject: [PATCH 10/11 linux-next] GenWQE: remove unnecessary version.h inclusion

Based on versioncheck.

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/misc/genwqe/card_base.h | 1 -
drivers/misc/genwqe/card_sysfs.c | 1 -
2 files changed, 2 deletions(-)

diff --git a/drivers/misc/genwqe/card_base.h b/drivers/misc/genwqe/card_base.h
index c64d7ca..e735344 100644
--- a/drivers/misc/genwqe/card_base.h
+++ b/drivers/misc/genwqe/card_base.h
@@ -34,7 +34,6 @@
#include <linux/semaphore.h>
#include <linux/uaccess.h>
#include <linux/io.h>
-#include <linux/version.h>
#include <linux/debugfs.h>
#include <linux/slab.h>

diff --git a/drivers/misc/genwqe/card_sysfs.c b/drivers/misc/genwqe/card_sysfs.c
index 2c33fbc..6ab31ef 100644
--- a/drivers/misc/genwqe/card_sysfs.c
+++ b/drivers/misc/genwqe/card_sysfs.c
@@ -24,7 +24,6 @@
* debugging, please also see the debugfs interfaces of this driver.
*/

-#include <linux/version.h>
#include <linux/kernel.h>
#include <linux/types.h>
#include <linux/module.h>
--
2.1.0

2014-12-29 14:34:50

by Fabian Frédérick

[permalink] [raw]
Subject: [PATCH 11/11 linux-next] s390/hmcdrv: remove unnecessary version.h inclusion

Based on versioncheck.

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/s390/char/hmcdrv_mod.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/s390/char/hmcdrv_mod.c b/drivers/s390/char/hmcdrv_mod.c
index 505c6a7..251a318 100644
--- a/drivers/s390/char/hmcdrv_mod.c
+++ b/drivers/s390/char/hmcdrv_mod.c
@@ -11,7 +11,6 @@
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/moduleparam.h>
-#include <linux/version.h>
#include <linux/stat.h>

#include "hmcdrv_ftp.h"
--
2.1.0

2014-12-29 18:33:01

by Dmitry Torokhov

[permalink] [raw]
Subject: Re: [PATCH 04/11 linux-next] input: remove unnecessary version.h inclusion

On Mon, Dec 29, 2014 at 03:29:38PM +0100, Fabian Frederick wrote:
> Based on versioncheck.
>
> Signed-off-by: Fabian Frederick <[email protected]>

Applied, thank you.

> ---
> drivers/input/touchscreen/elants_i2c.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
> index a510f7e..926c58e 100644
> --- a/drivers/input/touchscreen/elants_i2c.c
> +++ b/drivers/input/touchscreen/elants_i2c.c
> @@ -33,10 +33,8 @@
> #include <linux/delay.h>
> #include <linux/uaccess.h>
> #include <linux/buffer_head.h>
> -#include <linux/version.h>
> #include <linux/slab.h>
> #include <linux/firmware.h>
> -#include <linux/version.h>
> #include <linux/input/mt.h>
> #include <linux/acpi.h>
> #include <linux/of.h>
> --
> 2.1.0
>

--
Dmitry

2014-12-29 23:42:32

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [PATCH 09/11 linux-next] [media] uvcvideo: remove unnecessary version.h inclusion

Hi Fabian,

Thank you for the patch.

On Monday 29 December 2014 15:29:43 Fabian Frederick wrote:
> Based on versioncheck.
>
> Signed-off-by: Fabian Frederick <[email protected]>

Acked-by: Laurent Pinchart <[email protected]>

Should I take the patch in my tree or do you plan to send a pull request for
the whole series elsewhere ?

> ---
> drivers/media/usb/uvc/uvc_v4l2.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_v4l2.c
> b/drivers/media/usb/uvc/uvc_v4l2.c index 9c5cbcf..43e953f 100644
> --- a/drivers/media/usb/uvc/uvc_v4l2.c
> +++ b/drivers/media/usb/uvc/uvc_v4l2.c
> @@ -13,7 +13,6 @@
>
> #include <linux/compat.h>
> #include <linux/kernel.h>
> -#include <linux/version.h>
> #include <linux/list.h>
> #include <linux/module.h>
> #include <linux/slab.h>

--
Regards,

Laurent Pinchart

2014-12-30 10:06:32

by Fabian Frédérick

[permalink] [raw]
Subject: Re: [PATCH 09/11 linux-next] [media] uvcvideo: remove unnecessary version.h inclusion



> On 30 December 2014 at 00:42 Laurent Pinchart
> <[email protected]> wrote:
>
>
> Hi Fabian,
>
> Thank you for the patch.
>
> On Monday 29 December 2014 15:29:43 Fabian Frederick wrote:
> > Based on versioncheck.
> >
> > Signed-off-by: Fabian Frederick <[email protected]>
>
> Acked-by: Laurent Pinchart <[email protected]>
>
> Should I take the patch in my tree or do you plan to send a pull request for
> the whole series elsewhere ?
>
> > ---
> >  drivers/media/usb/uvc/uvc_v4l2.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/media/usb/uvc/uvc_v4l2.c
> > b/drivers/media/usb/uvc/uvc_v4l2.c index 9c5cbcf..43e953f 100644
> > --- a/drivers/media/usb/uvc/uvc_v4l2.c
> > +++ b/drivers/media/usb/uvc/uvc_v4l2.c
> > @@ -13,7 +13,6 @@
> >
> >  #include <linux/compat.h>
> >  #include <linux/kernel.h>
> > -#include <linux/version.h>
> >  #include <linux/list.h>
> >  #include <linux/module.h>
> >  #include <linux/slab.h>
>
> --
> Regards,
>
> Laurent Pinchart
>
Hi Laurent,

        Thanks for the ack, you can take the patch.
       
(Maybe Greg will try later to apply the whole patchset on linux-next.
It should not be a problem if some of them are already in.)

Regards,
Fabian