2014-12-31 16:46:01

by Rickard Strandqvist

[permalink] [raw]
Subject: [PATCH] net: ethernet: intel: i40e: i40e_fcoe.c: Remove unused function

Remove the function i40e_rx_is_fip() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <[email protected]>
---
drivers/net/ethernet/intel/i40e/i40e_fcoe.c | 9 ---------
1 file changed, 9 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c
index 5d01db1..20a5bfa 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c
@@ -39,15 +39,6 @@
#include "i40e_fcoe.h"

/**
- * i40e_rx_is_fip - returns true if the rx packet type is FIP
- * @ptype: the packet type field from rx descriptor write-back
- **/
-static inline bool i40e_rx_is_fip(u16 ptype)
-{
- return ptype == I40E_RX_PTYPE_L2_FIP_PAY2;
-}
-
-/**
* i40e_rx_is_fcoe - returns true if the rx packet type is FCoE
* @ptype: the packet type field from rx descriptor write-back
**/
--
1.7.10.4


2014-12-31 23:15:38

by Jeff Kirsher

[permalink] [raw]
Subject: Re: [PATCH] net: ethernet: intel: i40e: i40e_fcoe.c: Remove unused function

On Wed, 2014-12-31 at 17:48 +0100, Rickard Strandqvist wrote:
> Remove the function i40e_rx_is_fip() that is not used anywhere.
>
> This was partially found by using a static code analysis program
> called cppcheck.
>
> Signed-off-by: Rickard Strandqvist
> <[email protected]>
> ---
> drivers/net/ethernet/intel/i40e/i40e_fcoe.c | 9 ---------
> 1 file changed, 9 deletions(-)

Thanks Rickard! I thought I had some patches in my queue that started
to make use of that function, but come to find out, I don't... :-)

I will add your patch to my queue, thanks!


Attachments:
signature.asc (819.00 B)
This is a digitally signed message part