On Wed, Sep 6, 2023 at 7:39 AM Andrew Lunn <[email protected]> wrote:
>
> On Wed, Sep 06, 2023 at 04:51:42AM -0500, Adam Ford wrote:
> > Currently there is a device tree entry called "local-mac-address"
> > which can be filled by the bootloader or manually set.This is
> > useful when the user does not want to use the MAC address
> > programmed into the SoC.
> >
> > Currently, the davinci_emac reads the MAC from the DT, copies
> > it from pdata->mac_addr to priv->mac_addr, then blindly overwrites
> > it by reading from registers in the SoC, and falls back to a
> > random MAC if it's still not valid. This completely ignores any
> > MAC address in the device tree.
> >
> > In order to use the local-mac-address, check to see if the contents
> > of priv->mac_addr are valid before falling back to reading from the
> > SoC when the MAC address is not valid.
> >
> > Signed-off-by: Adam Ford <[email protected]>
>
> There is the potential for regressions here, since behaviour is being
> changed. But i do think what you are doing make sense.
>
> Reviewed-by: Andrew Lunn <[email protected]>
I don't know who the right person is to ask, but is there any chance
this can be accepted?
adam
>
> Andrew
> I don't know who the right person is to ask, but is there any chance
> this can be accepted?
It did not help you did not make it clear who you want to merge the
patches. It is a good idea to use To: with the Maintainer you would
like to do the merge and Cc: for the others.
What is the state of patches? Has the other patch been merged? If
just the driver change is left, please repost is on its own, and
follow:
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq
Andrew
On Wed, Oct 11, 2023 at 10:00 AM Andrew Lunn <[email protected]> wrote:
>
> > I don't know who the right person is to ask, but is there any chance
> > this can be accepted?
>
> It did not help you did not make it clear who you want to merge the
> patches. It is a good idea to use To: with the Maintainer you would
> like to do the merge and Cc: for the others.
I use ./scripts/get_maintainer to generate a list of maintainers for
the respective patches, and they should have all been CC'd.
>
> What is the state of patches? Has the other patch been merged? If
> just the driver change is left, please repost is on its own, and
> follow:
The device tree part has been accepted by Tony into the OMAP tree.
I'll split the driver off, do a V2, and just fetch the maintainer of
the driver itself and CC netdev.
>
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq
>
Thanks!
adam
> Andrew