2015-02-04 17:26:39

by Fabian Frédérick

Subject: [PATCH 1/1 linux-next] udf: remove bool assignment to 0/1

Fix the following coccinelle warnings:

fs/udf/inode.c:753:2-13: WARNING: Assignment of bool to 0/1
fs/udf/inode.c:795:2-13: WARNING: Assignment of bool to 0/1

Signed-off-by: Fabian Frederick <[email protected]>
---
fs/udf/inode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/udf/inode.c b/fs/udf/inode.c
index 7b72b7d..a445d59 100644
--- a/fs/udf/inode.c
+++ b/fs/udf/inode.c
@@ -750,7 +750,7 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
/* Are we beyond EOF? */
if (etype == -1) {
int ret;
- isBeyondEOF = 1;
+ isBeyondEOF = true;
if (count) {
if (c)
laarr[0] = laarr[1];
@@ -792,7 +792,7 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
endnum = c + 1;
lastblock = 1;
} else {
- isBeyondEOF = 0;
+ isBeyondEOF = false;
endnum = startnum = ((count > 2) ? 2 : count);

/* if the current extent is in position 0,
--
1.9.3

2015-02-05 15:37:23

by Jan Kara

Subject: Re: [PATCH 1/1 linux-next] udf: remove bool assignment to 0/1

On Wed 04-02-15 18:26:27, Fabian Frederick wrote:
> Fix the following coccinelle warnings:
>
> fs/udf/inode.c:753:2-13: WARNING: Assignment of bool to 0/1
> fs/udf/inode.c:795:2-13: WARNING: Assignment of bool to 0/1
Thanks for the fix. Patch merged.

Honza

>
> Signed-off-by: Fabian Frederick <[email protected]>
> ---
> fs/udf/inode.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/udf/inode.c b/fs/udf/inode.c
> index 7b72b7d..a445d59 100644
> --- a/fs/udf/inode.c
> +++ b/fs/udf/inode.c
> @@ -750,7 +750,7 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
> /* Are we beyond EOF? */
> if (etype == -1) {
> int ret;
> - isBeyondEOF = 1;
> + isBeyondEOF = true;
> if (count) {
> if (c)
> laarr[0] = laarr[1];
> @@ -792,7 +792,7 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
> endnum = c + 1;
> lastblock = 1;
> } else {
> - isBeyondEOF = 0;
> + isBeyondEOF = false;
> endnum = startnum = ((count > 2) ? 2 : count);
>
> /* if the current extent is in position 0,
> --
> 1.9.3
>
--
Jan Kara <[email protected]>
SUSE Labs, CR