2015-02-05 05:21:04

by Wang Long

Subject: [PATCH] Documentation: Fix the wrong command `echo -1 > set_ftrace_pid` for cleaning the filter.

The command `echo > set_ftrace_pid` should be used to clean the filter quietly.
because the command `echo -1 > set_ftrace_pid` will output the following:
"bash: echo: write error: Invalid argument".

so update the file Documentation/trace/ftrace.txt.

Signed-off-by: Wang Long <[email protected]>
---
Documentation/trace/ftrace.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/trace/ftrace.txt b/Documentation/trace/ftrace.txt
index 8408e04..572ca92 100644
--- a/Documentation/trace/ftrace.txt
+++ b/Documentation/trace/ftrace.txt
@@ -1740,7 +1740,7 @@ no pid
yum-updatesd-3111 [003] 1637.254683: lock_hrtimer_base <-hrtimer_try_to_cancel
yum-updatesd-3111 [003] 1637.254685: fget_light <-do_sys_poll
yum-updatesd-3111 [003] 1637.254686: pipe_poll <-do_sys_poll
-# echo -1 > set_ftrace_pid
+# echo > set_ftrace_pid
# cat trace |head
# tracer: function
#
--
1.8.3.4

2015-02-09 15:57:33

by Jonathan Corbet

Subject: Re: [PATCH] Documentation: Fix the wrong command `echo -1 > set_ftrace_pid` for cleaning the filter.

On Thu, 5 Feb 2015 05:16:14 +0000
Wang Long <[email protected]> wrote:

> The command `echo > set_ftrace_pid` should be used to clean the filter quietly.
> because the command `echo -1 > set_ftrace_pid` will output the following:
> "bash: echo: write error: Invalid argument".
>
> so update the file Documentation/trace/ftrace.txt.

So this is in my pile for the docs tree, but I was hoping to see an ack
from Steve first...?

Thanks,

jon

2015-02-09 16:02:22

by Steven Rostedt

Subject: Re: [PATCH] Documentation: Fix the wrong command `echo -1 > set_ftrace_pid` for cleaning the filter.

On Mon, 9 Feb 2015 10:57:29 -0500
Jonathan Corbet <[email protected]> wrote:

> On Thu, 5 Feb 2015 05:16:14 +0000
> Wang Long <[email protected]> wrote:
>
> > The command `echo > set_ftrace_pid` should be used to clean the filter quietly.
> > because the command `echo -1 > set_ftrace_pid` will output the following:
> > "bash: echo: write error: Invalid argument".
> >
> > so update the file Documentation/trace/ftrace.txt.
>
> So this is in my pile for the docs tree, but I was hoping to see an ack
> from Steve first...?

Yeah, I meant to reply but got distracted ;-)

Acked-by: Steven Rostedt <[email protected]>

-- Steve