2015-02-11 08:33:25

by Bas Peters

Subject: [PATCH] net: wireless: libertas: debugfs.c: remove unnecessary check before calling debugfs_remove

Debugfs_remove will check for error or NULL for us, so it is not
necessary to do this here.

Signed-off-by: Bas Peters <[email protected]>
---
drivers/net/wireless/libertas/debugfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wireless/libertas/debugfs.c b/drivers/net/wireless/libertas/debugfs.c
index cc6a0a5..26cbf1d 100644
--- a/drivers/net/wireless/libertas/debugfs.c
+++ b/drivers/net/wireless/libertas/debugfs.c
@@ -742,8 +742,7 @@ void lbs_debugfs_init(void)

void lbs_debugfs_remove(void)
{
- if (lbs_dir)
- debugfs_remove(lbs_dir);
+ debugfs_remove(lbs_dir);
}

void lbs_debugfs_init_one(struct lbs_private *priv, struct net_device *dev)
--
2.1.0

2015-02-27 08:07:23

by Kalle Valo

Subject: Re: libertas: remove unnecessary check before calling debugfs_remove

> Debugfs_remove will check for error or NULL for us, so it is not
> necessary to do this here.
>
> Signed-off-by: Bas Peters <[email protected]>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo