2015-02-14 12:10:32

by Fabian Frédérick

Subject: [PATCH 1/1 linux-next] btrfs: fix sizeof format specifier in btrfs_check_super_valid()

This patch fixes mips compilation warning:

fs/btrfs/disk-io.c: In function 'btrfs_check_super_valid':
fs/btrfs/disk-io.c:3927:21: warning: format '%lu' expects argument
of type 'long unsigned int', but argument 3 has type 'unsigned int' [-Wformat]

Signed-off-by: Fabian Frederick <[email protected]>
---
fs/btrfs/disk-io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index f79f385..639f266 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -3921,7 +3921,7 @@ static int btrfs_check_super_valid(struct btrfs_fs_info *fs_info,
}
if (btrfs_super_sys_array_size(sb) < sizeof(struct btrfs_disk_key)
+ sizeof(struct btrfs_chunk)) {
- printk(KERN_ERR "BTRFS: system chunk array too small %u < %lu\n",
+ printk(KERN_ERR "BTRFS: system chunk array too small %u < %zu\n",
btrfs_super_sys_array_size(sb),
sizeof(struct btrfs_disk_key)
+ sizeof(struct btrfs_chunk));
--
2.1.0

2015-02-22 11:20:18

by Geert Uytterhoeven

Subject: Re: [PATCH 1/1 linux-next] btrfs: fix sizeof format specifier in btrfs_check_super_valid()

On Sat, Feb 14, 2015 at 1:10 PM, Fabian Frederick <[email protected]> wrote:
> This patch fixes mips compilation warning:

Actually it happens on all 32-bit platforms (where size_t is unsigned int).

> fs/btrfs/disk-io.c: In function 'btrfs_check_super_valid':
> fs/btrfs/disk-io.c:3927:21: warning: format '%lu' expects argument
> of type 'long unsigned int', but argument 3 has type 'unsigned int' [-Wformat]
>
> Signed-off-by: Fabian Frederick <[email protected]>

Acked-by: Geert Uytterhoeven <[email protected]>

> ---
> fs/btrfs/disk-io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index f79f385..639f266 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -3921,7 +3921,7 @@ static int btrfs_check_super_valid(struct btrfs_fs_info *fs_info,
> }
> if (btrfs_super_sys_array_size(sb) < sizeof(struct btrfs_disk_key)
> + sizeof(struct btrfs_chunk)) {
> - printk(KERN_ERR "BTRFS: system chunk array too small %u < %lu\n",
> + printk(KERN_ERR "BTRFS: system chunk array too small %u < %zu\n",
> btrfs_super_sys_array_size(sb),
> sizeof(struct btrfs_disk_key)
> + sizeof(struct btrfs_chunk));

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds