2015-02-15 15:23:53

by Matwey V. Kornilov

Subject: [PATCH] of: Add prompt for OF_OVERLAY config

Signed-off-by: Matwey V. Kornilov <[email protected]>
---
drivers/of/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
index b5e0c87..fdca685 100644
--- a/drivers/of/Kconfig
+++ b/drivers/of/Kconfig
@@ -85,7 +85,7 @@ config OF_RESOLVE
bool

config OF_OVERLAY
- bool
+ bool "Device Tree overlays"
depends on OF
select OF_DYNAMIC
select OF_RESOLVE
--
2.1.4

2015-02-15 20:00:15

by Paul Bolle

Subject: Re: [PATCH] of: Add prompt for OF_OVERLAY config

On Sun, 2015-02-15 at 18:22 +0300, Matwey V. Kornilov wrote:
> Signed-off-by: Matwey V. Kornilov <[email protected]>
> ---
> drivers/of/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
> index b5e0c87..fdca685 100644
> --- a/drivers/of/Kconfig
> +++ b/drivers/of/Kconfig
> @@ -85,7 +85,7 @@ config OF_RESOLVE
> bool
>
> config OF_OVERLAY
> - bool
> + bool "Device Tree overlays"
> depends on OF
> select OF_DYNAMIC
> select OF_RESOLVE

Is this a bugfix (for the bug that OF_OVERLAY can't yet actually be set
to 'y') or not? Perhaps a commit explanation would have answered that
question.

By the way, "depends on OF" is superfluous (the enclosing menu already
depends on OF).


Paul Bolle

2015-02-16 06:21:47

by Matwey V. Kornilov

Subject: Re: [PATCH] of: Add prompt for OF_OVERLAY config

2015-02-15 23:00 GMT+03:00 Paul Bolle <[email protected]>:
> On Sun, 2015-02-15 at 18:22 +0300, Matwey V. Kornilov wrote:
>> Signed-off-by: Matwey V. Kornilov <[email protected]>
>> ---
>> drivers/of/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
>> index b5e0c87..fdca685 100644
>> --- a/drivers/of/Kconfig
>> +++ b/drivers/of/Kconfig
>> @@ -85,7 +85,7 @@ config OF_RESOLVE
>> bool
>>
>> config OF_OVERLAY
>> - bool
>> + bool "Device Tree overlays"
>> depends on OF
>> select OF_DYNAMIC
>> select OF_RESOLVE
>
> Is this a bugfix (for the bug that OF_OVERLAY can't yet actually be set
> to 'y') or not? Perhaps a commit explanation would have answered that
> question.

Yes it is. I thought it was trivial, I'll add message in v2

> By the way, "depends on OF" is superfluous (the enclosing menu already
> depends on OF).

Ok, but I'll put it in separate patch


--
With best regards,
Matwey V. Kornilov.
Sternberg Astronomical Institute, Lomonosov Moscow State University, Russia