2015-02-18 00:32:05

by Matthew Thode

Subject: [PATCH] reject creation of netdev names with colons

colons are used as a separator in netdev device lookup in dev_ioctl.c

Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME

Signed-off-by: Matthew Thode <[email protected]>
---
net/core/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index d030575..efbad386 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -946,7 +946,7 @@ bool dev_valid_name(const char *name)
return false;

while (*name) {
- if (*name == '/' || isspace(*name))
+ if (*name == '/' || *name == ':' || isspace(*name))
return false;
name++;
}
--
2.0.5

2015-02-22 02:46:09

by David Miller

Subject: Re: [PATCH] reject creation of netdev names with colons

From: Matthew Thode <[email protected]>
Date: Tue, 17 Feb 2015 18:31:57 -0600

> colons are used as a separator in netdev device lookup in dev_ioctl.c
>
> Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME
>
> Signed-off-by: Matthew Thode <[email protected]>

Applied thanks.

Please put a proper subsystem prefix in your Subject line
for future patches. In this case an appropriate prefix
would have been "net: reject..."