2015-02-18 19:13:20

by Davidlohr Bueso

Subject: [PATCH] arc: do not export symbols in troubleshoot.c

print_task_path_n_nm() is local to this file, its only
user being show_regs(). Mark the function static and avoid
the EXPORT_SYMBOL.

Signed-off-by: Davidlohr Bueso <[email protected]>
---

Compile tested only.

arch/arc/kernel/troubleshoot.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arc/kernel/troubleshoot.c b/arch/arc/kernel/troubleshoot.c
index 1badf9b..e00a018 100644
--- a/arch/arc/kernel/troubleshoot.c
+++ b/arch/arc/kernel/troubleshoot.c
@@ -52,7 +52,7 @@ static void show_callee_regs(struct callee_regs *cregs)
print_reg_file(&(cregs->r13), 13);
}

-void print_task_path_n_nm(struct task_struct *tsk, char *buf)
+static void print_task_path_n_nm(struct task_struct *tsk, char *buf)
{
struct path path;
char *path_nm = NULL;
@@ -77,7 +77,6 @@ void print_task_path_n_nm(struct task_struct *tsk, char *buf)
done:
pr_info("Path: %s\n", path_nm);
}
-EXPORT_SYMBOL(print_task_path_n_nm);

static void show_faulting_vma(unsigned long address, char *buf)
{
--
2.1.4

2015-02-18 19:20:40

by Davidlohr Bueso

Subject: Re: [PATCH] arc: do not export symbols in troubleshoot.c

On Wed, 2015-02-18 at 11:13 -0800, Davidlohr Bueso wrote:
> print_task_path_n_nm() is local to this file, its only
> user being show_regs(). Mark the function static and avoid
> the EXPORT_SYMBOL.
>
> Signed-off-by: Davidlohr Bueso <[email protected]>
> ---
>
> Compile tested only.

What am I saying! not tested. Got confused with another patch :)

2015-02-19 10:51:43

by Vineet Gupta

Subject: Re: [PATCH] arc: do not export symbols in troubleshoot.c

On Thursday 19 February 2015 12:50 AM, Davidlohr Bueso wrote:
> On Wed, 2015-02-18 at 11:13 -0800, Davidlohr Bueso wrote:
>> > print_task_path_n_nm() is local to this file, its only
>> > user being show_regs(). Mark the function static and avoid
>> > the EXPORT_SYMBOL.
>> >
>> > Signed-off-by: Davidlohr Bueso <[email protected]>
>> > ---
>> >
>> > Compile tested only.
> What am I saying! not tested. Got confused with another patch :)
>


And I got excited that core kernel developers are now starting to compile for ARC
:-) I'm sure we will get there.

Thx for the patch David.

Acked-by: Vineet Gupta <[email protected]>

-Vineet