2015-02-20 15:58:14

by Nicolas Ferre

Subject: [PATCH] pwm: atmel-hlcdc: add errata handling for sama5d4

sama5d4 SoC also has an errata on the HLCDC PWM. It is the same as the sama5d3
that is forbidding the use of div1 prescaler.

Signed-off-by: Nicolas Ferre <[email protected]>
---
drivers/pwm/pwm-atmel-hlcdc.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c
index 522f7075bb1a..fa5feaba25a5 100644
--- a/drivers/pwm/pwm-atmel-hlcdc.c
+++ b/drivers/pwm/pwm-atmel-hlcdc.c
@@ -225,6 +225,10 @@ static const struct of_device_id atmel_hlcdc_dt_ids[] = {
.compatible = "atmel,sama5d3-hlcdc",
.data = &atmel_hlcdc_pwm_sama5d3_errata,
},
+ {
+ .compatible = "atmel,sama5d4-hlcdc",
+ .data = &atmel_hlcdc_pwm_sama5d3_errata,
+ },
{ /* sentinel */ },
};

--
2.1.3

2015-02-20 16:06:41

by Boris Brezillon

Subject: Re: [PATCH] pwm: atmel-hlcdc: add errata handling for sama5d4

Hi Nicolas,

On Fri, 20 Feb 2015 16:58:18 +0100
Nicolas Ferre <[email protected]> wrote:

> sama5d4 SoC also has an errata on the HLCDC PWM. It is the same as the sama5d3
> that is forbidding the use of div1 prescaler.
>
> Signed-off-by: Nicolas Ferre <[email protected]>

The "atmel,sama5d4-hlcdc" compatible string is not yet documented in
the atmel-hlcdc MFD driver binding, but this shouldn't hurt, so

Acked-by: Boris Brezillon <[email protected]>

> ---
> drivers/pwm/pwm-atmel-hlcdc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c
> index 522f7075bb1a..fa5feaba25a5 100644
> --- a/drivers/pwm/pwm-atmel-hlcdc.c
> +++ b/drivers/pwm/pwm-atmel-hlcdc.c
> @@ -225,6 +225,10 @@ static const struct of_device_id atmel_hlcdc_dt_ids[] = {
> .compatible = "atmel,sama5d3-hlcdc",
> .data = &atmel_hlcdc_pwm_sama5d3_errata,
> },
> + {
> + .compatible = "atmel,sama5d4-hlcdc",
> + .data = &atmel_hlcdc_pwm_sama5d3_errata,
> + },
> { /* sentinel */ },
> };
>



--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

2015-02-20 16:26:39

by Nicolas Ferre

Subject: Re: [PATCH] pwm: atmel-hlcdc: add errata handling for sama5d4

Le 20/02/2015 17:06, Boris Brezillon a ?crit :
> Hi Nicolas,
>
> On Fri, 20 Feb 2015 16:58:18 +0100
> Nicolas Ferre <[email protected]> wrote:
>
>> sama5d4 SoC also has an errata on the HLCDC PWM. It is the same as the sama5d3
>> that is forbidding the use of div1 prescaler.
>>
>> Signed-off-by: Nicolas Ferre <[email protected]>
>
> The "atmel,sama5d4-hlcdc" compatible string is not yet documented in
> the atmel-hlcdc MFD driver binding, but this shouldn't hurt, so

Yes, I'll document it when I'm submitting your patches that add the
compatibility strings to the drivers/mfd/atmel-hlcdc.c. (with
atmel,at91sam9x5-hlcdc as well).

> Acked-by: Boris Brezillon <[email protected]>

Thanks, bye.

>> ---
>> drivers/pwm/pwm-atmel-hlcdc.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c
>> index 522f7075bb1a..fa5feaba25a5 100644
>> --- a/drivers/pwm/pwm-atmel-hlcdc.c
>> +++ b/drivers/pwm/pwm-atmel-hlcdc.c
>> @@ -225,6 +225,10 @@ static const struct of_device_id atmel_hlcdc_dt_ids[] = {
>> .compatible = "atmel,sama5d3-hlcdc",
>> .data = &atmel_hlcdc_pwm_sama5d3_errata,
>> },
>> + {
>> + .compatible = "atmel,sama5d4-hlcdc",
>> + .data = &atmel_hlcdc_pwm_sama5d3_errata,
>> + },
>> { /* sentinel */ },
>> };
>>
>
>
>


--
Nicolas Ferre