2015-02-20 22:24:32

by Alexey Khoroshilov

[permalink] [raw]

Subject: [PATCH] i40e: Fix memory leak at failure path in i40e_dbg_command_write()

---

The patch fixes a leak of 'cmd_buf' when copy_from_user() failed
in i40e_dbg_command_write().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <[email protected]>
---
drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
index 61236f983971..c17ee77100d3 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
@@ -989,8 +989,10 @@ static ssize_t i40e_dbg_command_write(struct file *filp,
if (!cmd_buf)
return count;
bytes_not_copied = copy_from_user(cmd_buf, buffer, count);
- if (bytes_not_copied < 0)
+ if (bytes_not_copied < 0) {
+ kfree(cmd_buf);
return bytes_not_copied;
+ }
if (bytes_not_copied > 0)
count -= bytes_not_copied;
cmd_buf[count] = '\0';
--
1.9.1

2015-02-20 23:28:43

by Jeff Kirsher

[permalink] [raw]

Subject: Re: [PATCH] i40e: Fix memory leak at failure path in i40e_dbg_command_write()

---

On Sat, 2015-02-21 at 01:24 +0300, Alexey Khoroshilov wrote:
> The patch fixes a leak of 'cmd_buf' when copy_from_user() failed
> in i40e_dbg_command_write().
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <[email protected]>
> ---
> drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)

Thanks Alexey, I have added your patch to my queue.

---

Attachments:

signature.asc (819.00 B)
This is a digitally signed message part