2015-02-22 21:40:48

by Ameen

Subject: [PATCH] __aligned(size) is preferred over __attribute__((aligned(size)))

Signed-off-by: Ameen Ali <[email protected]>
---
net/compat.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/net/compat.c b/net/compat.c
index 3236b41..49c6a8f 100644
--- a/net/compat.c
+++ b/net/compat.c
@@ -508,25 +508,25 @@ COMPAT_SYSCALL_DEFINE5(getsockopt, int, fd, int, level, int, optname,
struct compat_group_req {
__u32 gr_interface;
struct __kernel_sockaddr_storage gr_group
- __attribute__ ((aligned(4)));
+ __aligned(4);
} __packed;

struct compat_group_source_req {
__u32 gsr_interface;
struct __kernel_sockaddr_storage gsr_group
- __attribute__ ((aligned(4)));
+ __aligned(4);
struct __kernel_sockaddr_storage gsr_source
- __attribute__ ((aligned(4)));
+ __aligned(4);
} __packed;

struct compat_group_filter {
__u32 gf_interface;
struct __kernel_sockaddr_storage gf_group
- __attribute__ ((aligned(4)));
+ __aligned(4);
__u32 gf_fmode;
__u32 gf_numsrc;
struct __kernel_sockaddr_storage gf_slist[1]
- __attribute__ ((aligned(4)));
+ __aligned(4);
} __packed;

#define __COMPAT_GF0_SIZE (sizeof(struct compat_group_filter) - \
--
2.1.0

2015-02-22 22:02:41

by David Miller

Subject: Re: [PATCH] __aligned(size) is preferred over __attribute__((aligned(size)))

cFrom: Ameen Ali <[email protected]>
Date: Sun, 22 Feb 2015 23:40:36 +0200

> Signed-off-by: Ameen Ali <[email protected]>

Applied, but please use a proper Subject line next time,
in particular you should put a proper subsystem prefix.

In this case, "net: " would be an appropriate prefix.

Otherwise people scanning the shortlog in the repository
cannot tell where you are making your changes.

What if we had 100 commits all doing this same transformation?
It is the subsystem prefix that helps people see what is unique
in each such change.