2015-02-23 11:16:40

by Peter Senna Tschudin

Subject: [PATCH] staging/sm7xxfb: Make 'struct vgamode' static

sparse was complaining that symbol 'vgamode' was not declared.

Declaring vgamode as static.

Signed-off-by: Peter Senna Tschudin <[email protected]>
---
Tested by compilation only

drivers/staging/sm7xxfb/sm7xx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/sm7xxfb/sm7xx.h b/drivers/staging/sm7xxfb/sm7xx.h
index 7cc1896..c5d6253 100644
--- a/drivers/staging/sm7xxfb/sm7xx.h
+++ b/drivers/staging/sm7xxfb/sm7xx.h
@@ -119,7 +119,7 @@ struct ModeInit {
/**********************************************************************
SM712 Mode table.
**********************************************************************/
-struct ModeInit vgamode[] = {
+static struct ModeInit vgamode[] = {
{
/* mode#0: 640 x 480 16Bpp 60Hz */
640, 480, 16, 60,
--
2.1.0

2015-02-24 05:46:39

by Sudip Mukherjee

Subject: Re: [PATCH] staging/sm7xxfb: Make 'struct vgamode' static

On Mon, Feb 23, 2015 at 12:16:16PM +0100, Peter Senna Tschudin wrote:
> sparse was complaining that symbol 'vgamode' was not declared.
>
> Declaring vgamode as static.
a similar patch has already been sent to Greg, which is not yet applied.

regards
sudip

>
> Signed-off-by: Peter Senna Tschudin <[email protected]>
> ---
> --
> 2.1.0
>