2015-02-25 17:07:57

by Matt Porter

Subject: [PATCH] ARM: dts: am335x-boneblack: enable aes and sham

Beaglebone Black doesn't have AES and SHAM enabled like the
original Beaglebone White dts. This breaks applications that
leverage the crypto blocks so fix this by enabling these nodes.

Signed-off-by: Matt Porter <[email protected]>
---
arch/arm/boot/dts/am335x-boneblack.dts | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/am335x-boneblack.dts b/arch/arm/boot/dts/am335x-boneblack.dts
index 5c42d25..00853ff 100644
--- a/arch/arm/boot/dts/am335x-boneblack.dts
+++ b/arch/arm/boot/dts/am335x-boneblack.dts
@@ -33,6 +33,14 @@
status = "okay";
};

+&sham {
+ status = "okay";
+};
+
+&aes {
+ status = "okay";
+};
+
&am33xx_pinmux {
nxp_hdmi_bonelt_pins: nxp_hdmi_bonelt_pins {
pinctrl-single,pins = <
--
1.8.4

2015-02-25 18:36:14

by Robert Nelson

Subject: Re: [PATCH] ARM: dts: am335x-boneblack: enable aes and sham

On Wed, Feb 25, 2015 at 11:07 AM, Matt Porter <[email protected]> wrote:
> Beaglebone Black doesn't have AES and SHAM enabled like the
> original Beaglebone White dts. This breaks applications that
> leverage the crypto blocks so fix this by enabling these nodes.
>
> Signed-off-by: Matt Porter <[email protected]>
> ---
> arch/arm/boot/dts/am335x-boneblack.dts | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am335x-boneblack.dts b/arch/arm/boot/dts/am335x-boneblack.dts
> index 5c42d25..00853ff 100644
> --- a/arch/arm/boot/dts/am335x-boneblack.dts
> +++ b/arch/arm/boot/dts/am335x-boneblack.dts
> @@ -33,6 +33,14 @@
> status = "okay";
> };
>
> +&sham {
> + status = "okay";
> +};
> +
> +&aes {
> + status = "okay";
> +};
> +
> &am33xx_pinmux {
> nxp_hdmi_bonelt_pins: nxp_hdmi_bonelt_pins {
> pinctrl-single,pins = <
> --
> 1.8.4

Shouldn't we just move these to: "am335x-bone-common.dtsi" ?

(and then nuke the 6 lines in the am335x-bone.dts )

Regards,

--
Robert Nelson
http://www.rcn-ee.com/

2015-02-25 18:42:58

by Matt Porter

Subject: Re: [PATCH] ARM: dts: am335x-boneblack: enable aes and sham

On Wed, Feb 25, 2015 at 12:36:11PM -0600, Robert Nelson wrote:
> On Wed, Feb 25, 2015 at 11:07 AM, Matt Porter <[email protected]> wrote:
> > Beaglebone Black doesn't have AES and SHAM enabled like the
> > original Beaglebone White dts. This breaks applications that
> > leverage the crypto blocks so fix this by enabling these nodes.
> >
> > Signed-off-by: Matt Porter <[email protected]>
> > ---
> > arch/arm/boot/dts/am335x-boneblack.dts | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/am335x-boneblack.dts b/arch/arm/boot/dts/am335x-boneblack.dts
> > index 5c42d25..00853ff 100644
> > --- a/arch/arm/boot/dts/am335x-boneblack.dts
> > +++ b/arch/arm/boot/dts/am335x-boneblack.dts
> > @@ -33,6 +33,14 @@
> > status = "okay";
> > };
> >
> > +&sham {
> > + status = "okay";
> > +};
> > +
> > +&aes {
> > + status = "okay";
> > +};
> > +
> > &am33xx_pinmux {
> > nxp_hdmi_bonelt_pins: nxp_hdmi_bonelt_pins {
> > pinctrl-single,pins = <
> > --
> > 1.8.4
>
> Shouldn't we just move these to: "am335x-bone-common.dtsi" ?
>
> (and then nuke the 6 lines in the am335x-bone.dts )

Good idea, v2 on the way.

-Matt