2015-02-27 09:11:33

by Wanpeng Li

Subject: [PATCH] f2fs: don't need to collect dirty sit entries and flush journal when there's no dirty sit entries

Don't need to collect dirty sit entries and flush sit journal to sit
entries when there's no dirty sit entries. This patch check dirty_sentries
earlier just like flush_nat_entries.

Signed-off-by: Wanpeng Li <[email protected]>
---
fs/f2fs/segment.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index daee4ab..e7b83b6 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1730,6 +1730,9 @@ void flush_sit_entries(struct f2fs_sb_info *sbi, struct cp_control *cpc)
mutex_lock(&curseg->curseg_mutex);
mutex_lock(&sit_i->sentry_lock);

+ if (!sit_i->dirty_sentries)
+ goto out;
+
/*
* add and account sit entries of dirty bitmap in sit entry
* set temporarily
@@ -1744,9 +1747,6 @@ void flush_sit_entries(struct f2fs_sb_info *sbi, struct cp_control *cpc)
if (!__has_cursum_space(sum, sit_i->dirty_sentries, SIT_JOURNAL))
remove_sits_in_journal(sbi);

- if (!sit_i->dirty_sentries)
- goto out;
-
/*
* there are two steps to flush sit entries:
* #1, flush sit entries to journal in current cold data summary block.
--
1.9.1

2015-02-28 09:00:10

by Chao Yu

Subject: RE: [f2fs-dev] [PATCH] f2fs: don't need to collect dirty sit entries and flush journal when there's no dirty sit entries

> -----Original Message-----
> From: Wanpeng Li [mailto:[email protected]]
> Sent: Friday, February 27, 2015 4:53 PM
> To: Jaegeuk Kim
> Cc: [email protected]; Wanpeng Li; [email protected];
> [email protected]
> Subject: [f2fs-dev] [PATCH] f2fs: don't need to collect dirty sit entries and flush journal
> when there's no dirty sit entries
>
> Don't need to collect dirty sit entries and flush sit journal to sit
> entries when there's no dirty sit entries. This patch check dirty_sentries
> earlier just like flush_nat_entries.
>
> Signed-off-by: Wanpeng Li <[email protected]>

Reviewed-by: Chao Yu <[email protected]>