LinuxLists.cc - Rw: [PATCH] ALSA: hda - Add dock support for ThinkPad X250 (17aa:2226)

2015-04-11 09:40:52

Subject: Rw: [PATCH] ALSA: hda - Add dock support for ThinkPad X250 (17aa:2226)

Hi,

/me wonders why you didn't add the new line directly under "Thinkpad X240" :

SND_PCI_QUIRK(0x17aa, 0x2214, "Thinkpad X240", ALC292_FIXUP_TPT440_DOCK),
SND_PCI_QUIRK(0x17aa, 0x2215, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
+ SND_PCI_QUIRK(0x17aa, 0x2226, "ThinkPad X250", ALC292_FIXUP_TPT440_DOCK),
SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),

--
Toralf
pgp key: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 0076 E94E
--
"; the past is all dirty and cruel in the modern popular imagination, with the exception of the Romans, who are just cruel"
Ian Mortimer, 2008, "The Time Traveller's Guide to Medieval England"

2015-04-11 10:24:15

by Yves-Alexis Perez

[permalink] [raw]

Subject: Re: Rw: [PATCH] ALSA: hda - Add dock support for ThinkPad X250 (17aa:2226)

On sam., 2015-04-11 at 11:40 +0200, Toralf Förster wrote:
> Hi,
>
> /me wonders why you didn't add the new line directly under "Thinkpad X240" :
>
> SND_PCI_QUIRK(0x17aa, 0x2214, "Thinkpad X240", ALC292_FIXUP_TPT440_DOCK),
> SND_PCI_QUIRK(0x17aa, 0x2215, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
> + SND_PCI_QUIRK(0x17aa, 0x2226, "ThinkPad X250", ALC292_FIXUP_TPT440_DOCK),
> SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
>
The quirks seemed ordered by product ids so I just went this way.

Regards,
--
Yves-Alexis

Attachments:

signature.asc (473.00 B)
This is a digitally signed message part