2015-04-27 12:52:55

by Krzysztof Kozłowski

[permalink] [raw]
Subject: [PATCH] clk: at91: Constify irq_domain_ops

The irq_domain_ops are not modified by the driver and the irqdomain core
code accepts pointer to a const data.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/clk/at91/pmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c
index 3f27d21fb729..39be2be82b0a 100644
--- a/drivers/clk/at91/pmc.c
+++ b/drivers/clk/at91/pmc.c
@@ -153,7 +153,7 @@ static int pmc_irq_domain_xlate(struct irq_domain *d,
return 0;
}

-static struct irq_domain_ops pmc_irq_ops = {
+static const struct irq_domain_ops pmc_irq_ops = {
.map = pmc_irq_map,
.xlate = pmc_irq_domain_xlate,
};
--
2.1.0


2015-04-27 13:12:47

by Boris Brezillon

[permalink] [raw]
Subject: Re: [PATCH] clk: at91: Constify irq_domain_ops

On Mon, 27 Apr 2015 21:52:38 +0900
Krzysztof Kozlowski <[email protected]> wrote:

> The irq_domain_ops are not modified by the driver and the irqdomain core
> code accepts pointer to a const data.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Acked-by: Boris Brezillon <[email protected]>

> ---
> drivers/clk/at91/pmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c
> index 3f27d21fb729..39be2be82b0a 100644
> --- a/drivers/clk/at91/pmc.c
> +++ b/drivers/clk/at91/pmc.c
> @@ -153,7 +153,7 @@ static int pmc_irq_domain_xlate(struct irq_domain *d,
> return 0;
> }
>
> -static struct irq_domain_ops pmc_irq_ops = {
> +static const struct irq_domain_ops pmc_irq_ops = {
> .map = pmc_irq_map,
> .xlate = pmc_irq_domain_xlate,
> };



--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

2015-05-01 01:23:49

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH] clk: at91: Constify irq_domain_ops

On 04/27, Boris Brezillon wrote:
> On Mon, 27 Apr 2015 21:52:38 +0900
> Krzysztof Kozlowski <[email protected]> wrote:
>
> > The irq_domain_ops are not modified by the driver and the irqdomain core
> > code accepts pointer to a const data.
> >
> > Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> Acked-by: Boris Brezillon <[email protected]>
>

Thanks. Applied to clk-next.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project