2015-04-29 23:00:22

by Benjamin Poirier

Subject: [PATCH] mlx4_en: Use correct loop cursor in error path.

Signed-off-by: Benjamin Poirier <[email protected]>
Fixes: 9e311e7 ("net/mlx4_en: Use affinity hint")
---
drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
index 0f1afc0..bf173d7 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -1721,7 +1721,7 @@ mac_err:
cq_err:
while (rx_index--) {
mlx4_en_deactivate_cq(priv, priv->rx_cq[rx_index]);
- mlx4_en_free_affinity_hint(priv, i);
+ mlx4_en_free_affinity_hint(priv, rx_index);
}
for (i = 0; i < priv->rx_ring_num; i++)
mlx4_en_deactivate_rx_ring(priv, priv->rx_ring[i]);
--
2.3.5

2015-04-30 06:28:53

by Amir Vadai

Subject: Re: [PATCH] mlx4_en: Use correct loop cursor in error path.

On Thu, Apr 30, 2015 at 1:59 AM, Benjamin Poirier <[email protected]> wrote:
> Signed-off-by: Benjamin Poirier <[email protected]>
> Fixes: 9e311e7 ("net/mlx4_en: Use affinity hint")
> ---

Good catch.

Acked-by: Amir Vadai <[email protected]>

Thanks,
Amir

2015-04-30 20:26:01

by David Miller

Subject: Re: [PATCH] mlx4_en: Use correct loop cursor in error path.

From: Benjamin Poirier <[email protected]>
Date: Wed, 29 Apr 2015 15:59:35 -0700

> Signed-off-by: Benjamin Poirier <[email protected]>
> Fixes: 9e311e7 ("net/mlx4_en: Use affinity hint")

Applied, thanks.