2015-05-01 15:43:45

by Krzysztof Kozłowski

Subject: [PATCH] staging: iio: ad7606_par: Constify platform_device_id

The platform_device_id is not modified by the driver and core uses it as
const.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/staging/iio/adc/ad7606_par.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/adc/ad7606_par.c b/drivers/staging/iio/adc/ad7606_par.c
index 9e24b4d4455f..1d48ae381d16 100644
--- a/drivers/staging/iio/adc/ad7606_par.c
+++ b/drivers/staging/iio/adc/ad7606_par.c
@@ -119,7 +119,7 @@ static const struct dev_pm_ops ad7606_pm_ops = {
#define AD7606_PAR_PM_OPS NULL
#endif /* CONFIG_PM */

-static struct platform_device_id ad7606_driver_ids[] = {
+static const struct platform_device_id ad7606_driver_ids[] = {
{
.name = "ad7606-8",
.driver_data = ID_AD7606_8,
--
2.1.4

2015-05-02 17:48:55

by Lars-Peter Clausen

Subject: Re: [PATCH] staging: iio: ad7606_par: Constify platform_device_id

On 05/01/2015 05:43 PM, Krzysztof Kozlowski wrote:
> The platform_device_id is not modified by the driver and core uses it as
> const.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Acked-by: Lars-Peter Clausen <[email protected]>

Thanks.

> ---
> drivers/staging/iio/adc/ad7606_par.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/ad7606_par.c b/drivers/staging/iio/adc/ad7606_par.c
> index 9e24b4d4455f..1d48ae381d16 100644
> --- a/drivers/staging/iio/adc/ad7606_par.c
> +++ b/drivers/staging/iio/adc/ad7606_par.c
> @@ -119,7 +119,7 @@ static const struct dev_pm_ops ad7606_pm_ops = {
> #define AD7606_PAR_PM_OPS NULL
> #endif /* CONFIG_PM */
>
> -static struct platform_device_id ad7606_driver_ids[] = {
> +static const struct platform_device_id ad7606_driver_ids[] = {
> {
> .name = "ad7606-8",
> .driver_data = ID_AD7606_8,
>

2015-05-07 23:33:55

by Jonathan Cameron

Subject: Re: [PATCH] staging: iio: ad7606_par: Constify platform_device_id

On 02/05/15 18:48, Lars-Peter Clausen wrote:
> On 05/01/2015 05:43 PM, Krzysztof Kozlowski wrote:
>> The platform_device_id is not modified by the driver and core uses it as
>> const.
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> Acked-by: Lars-Peter Clausen <[email protected]>
>
> Thanks.
Applied to the togreg branch of iio.git which will be pushed out as
testing sometime soonish...

Thanks,

Jonathan
>
>> ---
>> drivers/staging/iio/adc/ad7606_par.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/iio/adc/ad7606_par.c b/drivers/staging/iio/adc/ad7606_par.c
>> index 9e24b4d4455f..1d48ae381d16 100644
>> --- a/drivers/staging/iio/adc/ad7606_par.c
>> +++ b/drivers/staging/iio/adc/ad7606_par.c
>> @@ -119,7 +119,7 @@ static const struct dev_pm_ops ad7606_pm_ops = {
>> #define AD7606_PAR_PM_OPS NULL
>> #endif /* CONFIG_PM */
>>
>> -static struct platform_device_id ad7606_driver_ids[] = {
>> +static const struct platform_device_id ad7606_driver_ids[] = {
>> {
>> .name = "ad7606-8",
>> .driver_data = ID_AD7606_8,
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html