2015-05-01 15:55:00

by Krzysztof Kozłowski

Subject: [PATCH 1/2] input: samsung-keypad: Constify platform_device_id

The platform_device_id is not modified by the driver and core uses it as
const.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/input/keyboard/samsung-keypad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/keyboard/samsung-keypad.c b/drivers/input/keyboard/samsung-keypad.c
index 6b9fdf6cf8e8..43e48dac7687 100644
--- a/drivers/input/keyboard/samsung-keypad.c
+++ b/drivers/input/keyboard/samsung-keypad.c
@@ -585,7 +585,7 @@ static const struct of_device_id samsung_keypad_dt_match[] = {
MODULE_DEVICE_TABLE(of, samsung_keypad_dt_match);
#endif

-static struct platform_device_id samsung_keypad_driver_ids[] = {
+static const struct platform_device_id samsung_keypad_driver_ids[] = {
{
.name = "samsung-keypad",
.driver_data = KEYPAD_TYPE_SAMSUNG,
--
2.1.4

2015-05-01 15:55:03

by Krzysztof Kozłowski

Subject: [PATCH 2/2] input: s3c2410_ts: Constify platform_device_id

The platform_device_id is not modified by the driver and core uses it as
const.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/input/touchscreen/s3c2410_ts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/s3c2410_ts.c b/drivers/input/touchscreen/s3c2410_ts.c
index bdfa27dc097b..a4a103e1d11b 100644
--- a/drivers/input/touchscreen/s3c2410_ts.c
+++ b/drivers/input/touchscreen/s3c2410_ts.c
@@ -411,7 +411,7 @@ static const struct dev_pm_ops s3c_ts_pmops = {
};
#endif

-static struct platform_device_id s3cts_driver_ids[] = {
+static const struct platform_device_id s3cts_driver_ids[] = {
{ "s3c2410-ts", 0 },
{ "s3c2440-ts", 0 },
{ "s3c64xx-ts", FEAT_PEN_IRQ },
--
2.1.4

2015-05-06 23:55:54

by Dmitry Torokhov

Subject: Re: [PATCH 2/2] input: s3c2410_ts: Constify platform_device_id

On Sat, May 02, 2015 at 12:53:07AM +0900, Krzysztof Kozlowski wrote:
> The platform_device_id is not modified by the driver and core uses it as
> const.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/input/touchscreen/s3c2410_ts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/s3c2410_ts.c b/drivers/input/touchscreen/s3c2410_ts.c
> index bdfa27dc097b..a4a103e1d11b 100644
> --- a/drivers/input/touchscreen/s3c2410_ts.c
> +++ b/drivers/input/touchscreen/s3c2410_ts.c
> @@ -411,7 +411,7 @@ static const struct dev_pm_ops s3c_ts_pmops = {
> };
> #endif
>
> -static struct platform_device_id s3cts_driver_ids[] = {
> +static const struct platform_device_id s3cts_driver_ids[] = {
> { "s3c2410-ts", 0 },
> { "s3c2440-ts", 0 },
> { "s3c64xx-ts", FEAT_PEN_IRQ },
> --
> 2.1.4
>

Applied both, thank you.

--
Dmitry