2015-05-04 11:47:19

by Nizam Haider

Subject: [PATCH] USB: core: buffer: fixed the checkpatch warning

Fixed two warnings sizeof name and Blank line after declaration

Signed-off-by: Nizam Haider <[email protected]>
---
drivers/usb/core/buffer.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/core/buffer.c b/drivers/usb/core/buffer.c
index 684ef70..04125b6 100644
--- a/drivers/usb/core/buffer.c
+++ b/drivers/usb/core/buffer.c
@@ -62,7 +62,7 @@ int hcd_buffer_create(struct usb_hcd *hcd)
size = pool_max[i];
if (!size)
continue;
- snprintf(name, sizeof name, "buffer-%d", size);
+ snprintf(name, sizeof(name), "buffer-%d", size);
hcd->pool[i] = dma_pool_create(name, hcd->self.controller,
size, size, 0);
if (!hcd->pool[i]) {
@@ -87,6 +87,7 @@ void hcd_buffer_destroy(struct usb_hcd *hcd)

for (i = 0; i < HCD_BUFFER_POOLS; i++) {
struct dma_pool *pool = hcd->pool[i];
+
if (pool) {
dma_pool_destroy(pool);
hcd->pool[i] = NULL;
--
1.8.1.4

2015-05-05 22:14:14

by Greg Kroah-Hartman

Subject: Re: [PATCH] USB: core: buffer: fixed the checkpatch warning

On Mon, May 04, 2015 at 11:45:23AM +0530, Nizam Haider wrote:
> Fixed two warnings sizeof name and Blank line after declaration

That's two different things, please send two different patches.

thanks,

greg k-h