2015-05-09 08:14:57

by Xi Wang

Subject: [PATCH net-next] test: bpf: extend "load 64-bit immediate" testcase

Extend the testcase to catch a signedness bug in the arm64 JIT:

test_bpf: #58 load 64-bit immediate jited:1 ret -1 != 1 FAIL (1 times)

This is useful to ensure other JITs won't have a similar bug.

Link: https://lkml.org/lkml/2015/5/8/458
Cc: Alexei Starovoitov <[email protected]>
Cc: Will Deacon <[email protected]>
Signed-off-by: Xi Wang <[email protected]>
---
lib/test_bpf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/test_bpf.c b/lib/test_bpf.c
index f2c23ffaa6d7..3c41049d72d8 100644
--- a/lib/test_bpf.c
+++ b/lib/test_bpf.c
@@ -1755,7 +1755,8 @@ static struct bpf_test tests[] = {
BPF_EXIT_INSN(),
BPF_JMP_IMM(BPF_JEQ, R3, 0x1234, 1),
BPF_EXIT_INSN(),
- BPF_ALU64_IMM(BPF_MOV, R0, 1),
+ BPF_LD_IMM64(R0, 0x1ffffffffLL),
+ BPF_ALU64_IMM(BPF_RSH, R0, 32), /* R0 = 1 */
BPF_EXIT_INSN(),
},
INTERNAL,
--
1.9.1

2015-05-09 16:11:12

by Alexei Starovoitov

Subject: Re: [PATCH net-next] test: bpf: extend "load 64-bit immediate" testcase

On 5/9/15 1:14 AM, Xi Wang wrote:
> Extend the testcase to catch a signedness bug in the arm64 JIT:
>
> test_bpf: #58 load 64-bit immediate jited:1 ret -1 != 1 FAIL (1 times)
>
> This is useful to ensure other JITs won't have a similar bug.
>
> Link: https://lkml.org/lkml/2015/5/8/458
> Cc: Alexei Starovoitov <[email protected]>
> Cc: Will Deacon <[email protected]>
> Signed-off-by: Xi Wang <[email protected]>
> ---

looks good. Thanks!

Acked-by: Alexei Starovoitov <[email protected]>

2015-05-09 21:12:27

by Daniel Borkmann

Subject: Re: [PATCH net-next] test: bpf: extend "load 64-bit immediate" testcase

On 05/09/2015 10:14 AM, Xi Wang wrote:
> Extend the testcase to catch a signedness bug in the arm64 JIT:
>
> test_bpf: #58 load 64-bit immediate jited:1 ret -1 != 1 FAIL (1 times)
>
> This is useful to ensure other JITs won't have a similar bug.
>
> Link: https://lkml.org/lkml/2015/5/8/458
> Cc: Alexei Starovoitov <[email protected]>
> Cc: Will Deacon <[email protected]>
> Signed-off-by: Xi Wang <[email protected]>

Acked-by: Daniel Borkmann <[email protected]>

2015-05-11 15:02:48

by David Miller

Subject: Re: [PATCH net-next] test: bpf: extend "load 64-bit immediate" testcase

From: Xi Wang <[email protected]>
Date: Sat, 9 May 2015 04:14:30 -0400

> Extend the testcase to catch a signedness bug in the arm64 JIT:
>
> test_bpf: #58 load 64-bit immediate jited:1 ret -1 != 1 FAIL (1 times)
>
> This is useful to ensure other JITs won't have a similar bug.
>
> Link: https://lkml.org/lkml/2015/5/8/458
> Cc: Alexei Starovoitov <[email protected]>
> Cc: Will Deacon <[email protected]>
> Signed-off-by: Xi Wang <[email protected]>

Applied, thank you.