2015-05-15 21:26:40

by Fabian Frédérick

Subject: [PATCH 1/1 linux-next] udf: remove double err declaration in udf_file_write_iter()

Use first err declaration for generic_write_sync() return value.

Signed-off-by: Fabian Frederick <[email protected]>
---
fs/udf/file.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/udf/file.c b/fs/udf/file.c
index 7a95b8f..bddf3d0 100644
--- a/fs/udf/file.c
+++ b/fs/udf/file.c
@@ -152,8 +152,6 @@ out:
mutex_unlock(&inode->i_mutex);

if (retval > 0) {
- ssize_t err;
-
mark_inode_dirty(inode);
err = generic_write_sync(file, iocb->ki_pos - retval, retval);
if (err < 0)
--
2.4.0

2015-05-18 06:17:00

by Jan Kara

Subject: Re: [PATCH 1/1 linux-next] udf: remove double err declaration in udf_file_write_iter()

On Fri 15-05-15 23:26:28, Fabian Frederick wrote:
> Use first err declaration for generic_write_sync() return value.
Thanks. I've merged the patch.

Honza

>
> Signed-off-by: Fabian Frederick <[email protected]>
> ---
> fs/udf/file.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/udf/file.c b/fs/udf/file.c
> index 7a95b8f..bddf3d0 100644
> --- a/fs/udf/file.c
> +++ b/fs/udf/file.c
> @@ -152,8 +152,6 @@ out:
> mutex_unlock(&inode->i_mutex);
>
> if (retval > 0) {
> - ssize_t err;
> -
> mark_inode_dirty(inode);
> err = generic_write_sync(file, iocb->ki_pos - retval, retval);
> if (err < 0)
> --
> 2.4.0
>
--
Jan Kara <[email protected]>
SUSE Labs, CR