2015-05-20 02:46:28

by Cory Tusar

Subject: [PATCH] ARM: dts: vf610: Extend I2C support to all available busses.

This commit extends the existing Vybrid I2C support to cover busses
I2C1, I2C2, and I2C3.

Signed-off-by: Cory Tusar <[email protected]>
---
arch/arm/boot/dts/vfxxx.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)

diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
index 4aa3351..ec98b6c 100644
--- a/arch/arm/boot/dts/vfxxx.dtsi
+++ b/arch/arm/boot/dts/vfxxx.dtsi
@@ -347,6 +347,48 @@
status = "disabled";
};

+ i2c1: i2c@40067000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "fsl,vf610-i2c";
+ reg = <0x40067000 0x1000>;
+ interrupts = <72 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clks VF610_CLK_I2C1>;
+ clock-names = "ipg";
+ dmas = <&edma0 0 52>,
+ <&edma0 0 53>;
+ dma-names = "rx","tx";
+ status = "disabled";
+ };
+
+ i2c2: i2c@400e6000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "fsl,vf610-i2c";
+ reg = <0x400e6000 0x1000>;
+ interrupts = <73 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clks VF610_CLK_I2C2>;
+ clock-names = "ipg";
+ dmas = <&edma0 1 36>,
+ <&edma0 1 37>;
+ dma-names = "rx","tx";
+ status = "disabled";
+ };
+
+ i2c3: i2c@400e7000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "fsl,vf610-i2c";
+ reg = <0x400e7000 0x1000>;
+ interrupts = <74 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clks VF610_CLK_I2C3>;
+ clock-names = "ipg";
+ dmas = <&edma0 1 38>,
+ <&edma0 1 39>;
+ dma-names = "rx","tx";
+ status = "disabled";
+ };
+
clks: ccm@4006b000 {
compatible = "fsl,vf610-ccm";
reg = <0x4006b000 0x1000>;
--
2.3.6

2015-05-20 13:31:47

by Cory Tusar

Subject: Re: [PATCH] ARM: dts: vf610: Extend I2C support to all available busses.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/19/2015 10:45 PM, Cory Tusar wrote:
> This commit extends the existing Vybrid I2C support to cover busses
> I2C1, I2C2, and I2C3.

And...I'm going to NAK my version of this patch - the i2c2 and i2c3
mappings should be under aips1 rather than aips0.

Also, I see that Stefan has a similar change up in the linux-toradex
tree:

http://git.toradex.com/cgit/linux-toradex.git/commit/arch/arm/boot/dts/vfxxx.dtsi?h=toradex_vf_4.0&id=7863765e0f3d2a20a0a69e49c44c1e2f96608c8f

I'll follow-up with him directly about resolving differences in our two
implementations.

- -Cory


> Signed-off-by: Cory Tusar <[email protected]>
> ---
> arch/arm/boot/dts/vfxxx.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> index 4aa3351..ec98b6c 100644
> --- a/arch/arm/boot/dts/vfxxx.dtsi
> +++ b/arch/arm/boot/dts/vfxxx.dtsi
> @@ -347,6 +347,48 @@
> status = "disabled";
> };
>
> + i2c1: i2c@40067000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "fsl,vf610-i2c";
> + reg = <0x40067000 0x1000>;
> + interrupts = <72 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clks VF610_CLK_I2C1>;
> + clock-names = "ipg";
> + dmas = <&edma0 0 52>,
> + <&edma0 0 53>;
> + dma-names = "rx","tx";
> + status = "disabled";
> + };
> +
> + i2c2: i2c@400e6000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "fsl,vf610-i2c";
> + reg = <0x400e6000 0x1000>;
> + interrupts = <73 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clks VF610_CLK_I2C2>;
> + clock-names = "ipg";
> + dmas = <&edma0 1 36>,
> + <&edma0 1 37>;
> + dma-names = "rx","tx";
> + status = "disabled";
> + };
> +
> + i2c3: i2c@400e7000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "fsl,vf610-i2c";
> + reg = <0x400e7000 0x1000>;
> + interrupts = <74 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clks VF610_CLK_I2C3>;
> + clock-names = "ipg";
> + dmas = <&edma0 1 38>,
> + <&edma0 1 39>;
> + dma-names = "rx","tx";
> + status = "disabled";
> + };
> +
> clks: ccm@4006b000 {
> compatible = "fsl,vf610-ccm";
> reg = <0x4006b000 0x1000>;
>


- --
Cory T. Tusar
Principal
PID 1 Solutions, Inc.
(814) 553-8619


"There are two ways of constructing a software design. One way is to
make it so simple that there are obviously no deficiencies, and the
other way is to make it so complicated that there are no obvious
deficiencies." --Sir Charles Anthony Richard Hoare

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlVcjL0ACgkQHT1tsfGwHJ9szACfVfARbngdf0C1ZjNSvzzIMwlW
eAkAn2ne/PAOKBZVH/L4FP0Qmi+GWJLu
=FpuI
-----END PGP SIGNATURE-----