2015-05-20 14:57:40

by Stephane Viau

Subject: [PATCH] drm/msm/mdp5: fix incorrect parameter for msm_framebuffer_iova()

The index of ->planes[] array (3rd parameter) cannot be equal to MAX_PLANE.
This looks like a typo that is now fixed.

Signed-off-by: Stephane Viau <[email protected]>
---
drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
index 18a3d20..57b8f56 100644
--- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
+++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
@@ -273,7 +273,7 @@ static void set_scanout_locked(struct drm_plane *plane,
mdp5_write(mdp5_kms, REG_MDP5_PIPE_SRC2_ADDR(pipe),
msm_framebuffer_iova(fb, mdp5_kms->id, 2));
mdp5_write(mdp5_kms, REG_MDP5_PIPE_SRC3_ADDR(pipe),
- msm_framebuffer_iova(fb, mdp5_kms->id, 4));
+ msm_framebuffer_iova(fb, mdp5_kms->id, 3));

plane->fb = fb;
}
--
Qualcomm Innovation Center, Inc.

The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

2015-05-20 15:30:07

by Rob Clark

Subject: Re: [PATCH] drm/msm/mdp5: fix incorrect parameter for msm_framebuffer_iova()

On Wed, May 20, 2015 at 10:57 AM, Stephane Viau <[email protected]> wrote:
> The index of ->planes[] array (3rd parameter) cannot be equal to MAX_PLANE.
> This looks like a typo that is now fixed.
>
> Signed-off-by: Stephane Viau <[email protected]>

Acked-by: Rob Clark <[email protected]>

Dave, since it looks like you've merged my earlier fixes pull but
haven't sent to linus yet, do you mind applying this one directly on
msm-fixes?

BR,
-R

> ---
> drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
> index 18a3d20..57b8f56 100644
> --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
> +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
> @@ -273,7 +273,7 @@ static void set_scanout_locked(struct drm_plane *plane,
> mdp5_write(mdp5_kms, REG_MDP5_PIPE_SRC2_ADDR(pipe),
> msm_framebuffer_iova(fb, mdp5_kms->id, 2));
> mdp5_write(mdp5_kms, REG_MDP5_PIPE_SRC3_ADDR(pipe),
> - msm_framebuffer_iova(fb, mdp5_kms->id, 4));
> + msm_framebuffer_iova(fb, mdp5_kms->id, 3));
>
> plane->fb = fb;
> }
> --
> Qualcomm Innovation Center, Inc.
>
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
>