2015-05-20 15:02:36

by Ivan T. Ivanov

Subject: [PATCH] coresight-etm3x: Add Qualcomm PFT v1.1 peripheral ID

Add Qualcomm's PFT v1.1 peripheral ID to supported devices.
This device could be found at least in MSM8974 and APQ8064
chipsets.

Signed-off-by: Ivan T. Ivanov <[email protected]>
---
drivers/hwtracing/coresight/coresight-etm3x.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c b/drivers/hwtracing/coresight/coresight-etm3x.c
index 018a00f..e13520f 100644
--- a/drivers/hwtracing/coresight/coresight-etm3x.c
+++ b/drivers/hwtracing/coresight/coresight-etm3x.c
@@ -1912,6 +1912,11 @@ static struct amba_id etm_ids[] = {
.mask = 0x0003ffff,
.data = "PTM 1.1",
},
+ { /* PFT 1.1 Qualcomm */
+ .id = 0x0003006f,
+ .mask = 0x0003ffff,
+ .data = "PFT 1.1",
+ },
{ 0, 0},
};

--
1.9.1

2015-05-21 14:10:59

by Mathieu Poirier

Subject: Re: [PATCH] coresight-etm3x: Add Qualcomm PFT v1.1 peripheral ID

On 20 May 2015 at 09:02, Ivan T. Ivanov <[email protected]> wrote:
> Add Qualcomm's PFT v1.1 peripheral ID to supported devices.
> This device could be found at least in MSM8974 and APQ8064
> chipsets.
>
> Signed-off-by: Ivan T. Ivanov <[email protected]>
> ---
> drivers/hwtracing/coresight/coresight-etm3x.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c b/drivers/hwtracing/coresight/coresight-etm3x.c
> index 018a00f..e13520f 100644
> --- a/drivers/hwtracing/coresight/coresight-etm3x.c
> +++ b/drivers/hwtracing/coresight/coresight-etm3x.c
> @@ -1912,6 +1912,11 @@ static struct amba_id etm_ids[] = {
> .mask = 0x0003ffff,
> .data = "PTM 1.1",
> },
> + { /* PFT 1.1 Qualcomm */
> + .id = 0x0003006f,
> + .mask = 0x0003ffff,
> + .data = "PFT 1.1",
> + },
> { 0, 0},
> };

I'm essentially good with that. On the flip side "PFT" is the format
of the output generated by the tracer. What is important to identify
is the type of tracer fitted to the SoC, either "ETM" or "PTM".

>
> --
> 1.9.1
>

2015-05-21 15:24:32

by Ivan T. Ivanov

Subject: Re: [PATCH] coresight-etm3x: Add Qualcomm PFT v1.1 peripheral ID

On Thu, 2015-05-21 at 08:10 -0600, Mathieu Poirier wrote:
> On 20 May 2015 at 09:02, Ivan T. Ivanov [email protected]> wrote:
> > Add Qualcomm's PFT v1.1 peripheral ID to supported devices.
> > This device could be found at least in MSM8974 and APQ8064
> > chipsets.
> >
> > Signed-off-by: Ivan T. Ivanov [email protected]>
> > ---
> > drivers/hwtracing/coresight/coresight-etm3x.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c
> > b/drivers/hwtracing/coresight/coresight-etm3x.c
> > index 018a00f..e13520f 100644
> > --- a/drivers/hwtracing/coresight/coresight-etm3x.c
> > +++ b/drivers/hwtracing/coresight/coresight-etm3x.c
> > @@ -1912,6 +1912,11 @@ static struct amba_id etm_ids[] = {
> > .mask = 0x0003ffff,
> > .data = "PTM 1.1",
> > },
> > + { /* PFT 1.1 Qualcomm */
> > + .id = 0x0003006f,
> > + .mask = 0x0003ffff,
> > + .data = "PFT 1.1",
> > + },
> > { 0, 0},
> > };
>
> I'm essentially good with that. On the flip side "PFT" is the format
> of the output generated by the tracer. What is important to identify
> is the type of tracer fitted to the SoC, either "ETM" or "PTM".

I was unable to find PTM 1.1 in the ARM documentation and PFT
v1.1 is supported only by PTM, if understand it correctly.

Regards,
Ivan

2015-05-22 13:57:49

by Mathieu Poirier

Subject: Re: [PATCH] coresight-etm3x: Add Qualcomm PFT v1.1 peripheral ID

On 21 May 2015 at 09:24, Ivan T. Ivanov <[email protected]> wrote:
>
> On Thu, 2015-05-21 at 08:10 -0600, Mathieu Poirier wrote:
>> On 20 May 2015 at 09:02, Ivan T. Ivanov [email protected]> wrote:
>> > Add Qualcomm's PFT v1.1 peripheral ID to supported devices.
>> > This device could be found at least in MSM8974 and APQ8064
>> > chipsets.
>> >
>> > Signed-off-by: Ivan T. Ivanov [email protected]>
>> > ---
>> > drivers/hwtracing/coresight/coresight-etm3x.c | 5 +++++
>> > 1 file changed, 5 insertions(+)
>> >
>> > diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c
>> > b/drivers/hwtracing/coresight/coresight-etm3x.c
>> > index 018a00f..e13520f 100644
>> > --- a/drivers/hwtracing/coresight/coresight-etm3x.c
>> > +++ b/drivers/hwtracing/coresight/coresight-etm3x.c
>> > @@ -1912,6 +1912,11 @@ static struct amba_id etm_ids[] = {
>> > .mask = 0x0003ffff,
>> > .data = "PTM 1.1",
>> > },
>> > + { /* PFT 1.1 Qualcomm */
>> > + .id = 0x0003006f,
>> > + .mask = 0x0003ffff,
>> > + .data = "PFT 1.1",
>> > + },
>> > { 0, 0},
>> > };
>>
>> I'm essentially good with that. On the flip side "PFT" is the format
>> of the output generated by the tracer. What is important to identify
>> is the type of tracer fitted to the SoC, either "ETM" or "PTM".
>
> I was unable to find PTM 1.1 in the ARM documentation and PFT
> v1.1 is supported only by PTM, if understand it correctly.
>
> Regards,
> Ivan

It does not change anything - PFT is the protocol and PTM is the tracer.