2015-05-25 17:33:26

by Shailendra Verma

Subject: [PATCH] Input:mouse:synaptics_i2c - Use bool function return value

The function synaptics_i2c_get_input() has bool return type.
So use bool value flase instead of 0 to return.

Signed-off-by: Shailendra Verma <[email protected]>
---
drivers/input/mouse/synaptics_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/mouse/synaptics_i2c.c b/drivers/input/mouse/synaptics_i2c.c
index 2c87a93..ffceedc 100644
--- a/drivers/input/mouse/synaptics_i2c.c
+++ b/drivers/input/mouse/synaptics_i2c.c
@@ -342,7 +342,7 @@ static bool synaptics_i2c_get_input(struct synaptics_i2c *touch)

/* Deal with spontaneous resets and errors */
if (synaptics_i2c_check_error(touch->client))
- return 0;
+ return false;

/* Get Gesture Bit */
data = synaptics_i2c_reg_get(touch->client, DATA_REG0);
--
1.7.9.5

2015-05-26 21:44:15

by Dmitry Torokhov

Subject: Re: [PATCH] Input:mouse:synaptics_i2c - Use bool function return value

On Mon, May 25, 2015 at 11:03:04PM +0530, Shailendra Verma wrote:
> The function synaptics_i2c_get_input() has bool return type.
> So use bool value flase instead of 0 to return.
>
> Signed-off-by: Shailendra Verma <[email protected]>

Folded all 3 patches together and applied.

Thank you.

> ---
> drivers/input/mouse/synaptics_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/synaptics_i2c.c b/drivers/input/mouse/synaptics_i2c.c
> index 2c87a93..ffceedc 100644
> --- a/drivers/input/mouse/synaptics_i2c.c
> +++ b/drivers/input/mouse/synaptics_i2c.c
> @@ -342,7 +342,7 @@ static bool synaptics_i2c_get_input(struct synaptics_i2c *touch)
>
> /* Deal with spontaneous resets and errors */
> if (synaptics_i2c_check_error(touch->client))
> - return 0;
> + return false;
>
> /* Get Gesture Bit */
> data = synaptics_i2c_reg_get(touch->client, DATA_REG0);
> --
> 1.7.9.5
>

--
Dmitry