2015-05-27 01:20:33

by Shailendra Verma

Subject: [PATCH] atm:he - Change 0 to false for bool type variable initialization.

The variable sdh is bool type so initializing it with false value
instead of 0.

Signed-off-by: Shailendra Verma <[email protected]>
---
drivers/atm/he.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/atm/he.c b/drivers/atm/he.c
index 93dca2e..eb5bebc 100644
--- a/drivers/atm/he.c
+++ b/drivers/atm/he.c
@@ -116,8 +116,8 @@ static bool disable64;
static short nvpibits = -1;
static short nvcibits = -1;
static short rx_skb_reserve = 16;
-static bool irq_coalesce = 1;
-static bool sdh = 0;
+static bool irq_coalesce = true;
+static bool sdh = false;

/* Read from EEPROM = 0000 0011b */
static unsigned int readtab[] = {
--
1.7.9.5

2015-05-27 02:59:38

by David Miller

Subject: Re: [PATCH] atm:he - Change 0 to false for bool type variable initialization.

From: Shailendra Verma <[email protected]>
Date: Wed, 27 May 2015 06:50:18 +0530

> The variable sdh is bool type so initializing it with false value
> instead of 0.
>
> Signed-off-by: Shailendra Verma <[email protected]>
> ---
> drivers/atm/he.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/atm/he.c b/drivers/atm/he.c
> index 93dca2e..eb5bebc 100644
> --- a/drivers/atm/he.c
> +++ b/drivers/atm/he.c
> @@ -116,8 +116,8 @@ static bool disable64;
> static short nvpibits = -1;
> static short nvcibits = -1;
> static short rx_skb_reserve = 16;
> -static bool irq_coalesce = 1;
> -static bool sdh = 0;
> +static bool irq_coalesce = true;
> +static bool sdh = false;

You didn't understand my feedback.

I already applied your patch that handled the irq_coalesce issue,
so you have to submit a patch relative to that.

In fact, you should always test that your patch applied to my tree
before submitting it.