2015-06-01 11:56:24

by Baolin Wang

Subject: [PATCH v4 07/25] posix-timers:Change the implementation for timer_gettime syscall function

This patch splits out the guts of the timer_gettime syscall and changes the
timer_gettime syscall implementation to prepare the converting to 64bit methods
for the timer_gettime syscall function in posix-timers.c file.

Signed-off-by: Baolin Wang <[email protected]>
---
kernel/time/posix-timers.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/kernel/time/posix-timers.c b/kernel/time/posix-timers.c
index 96efe1d..d00f8ed 100644
--- a/kernel/time/posix-timers.c
+++ b/kernel/time/posix-timers.c
@@ -795,11 +795,8 @@ common_timer_get(struct k_itimer *timr, struct itimerspec *cur_setting)
cur_setting->it_value = ktime_to_timespec(remaining);
}

-/* Get the time remaining on a POSIX.1b interval timer. */
-SYSCALL_DEFINE2(timer_gettime, timer_t, timer_id,
- struct itimerspec __user *, setting)
+static int __timer_gettime(timer_t timer_id, struct itimerspec *cur_setting)
{
- struct itimerspec cur_setting;
struct k_itimer *timr;
struct k_clock *kc;
unsigned long flags;
@@ -813,9 +810,18 @@ SYSCALL_DEFINE2(timer_gettime, timer_t, timer_id,
if (WARN_ON_ONCE(!kc || !kc->timer_get))
ret = -EINVAL;
else
- kc->timer_get(timr, &cur_setting);
+ kc->timer_get(timr, cur_setting);

unlock_timer(timr, flags);
+ return ret;
+}
+
+/* Get the time remaining on a POSIX.1b interval timer. */
+SYSCALL_DEFINE2(timer_gettime, timer_t, timer_id,
+ struct itimerspec __user *, setting)
+{
+ struct itimerspec cur_setting;
+ int ret = __timer_gettime(timer_id, &cur_setting);

if (!ret && copy_to_user(setting, &cur_setting, sizeof (cur_setting)))
return -EFAULT;
--
1.7.9.5

2015-06-02 19:20:25

by Thomas Gleixner

Subject: Re: [PATCH v4 07/25] posix-timers:Change the implementation for timer_gettime syscall function

On Mon, 1 Jun 2015, Baolin Wang wrote:

That's a new variant of useless subject lines. Sigh.

> This patch splits out the guts of the timer_gettime syscall and changes the
> timer_gettime syscall implementation to prepare the converting to 64bit methods
> for the timer_gettime syscall function in posix-timers.c file.

Your supply of useless information like the file name of the file
which is changed by the patch seems to be endless.

Thanks,

tglx