2015-06-01 13:11:06

by Angel Shtilianov

[permalink] [raw]
Subject: [PATCH] fsnotify: Remove obsolete documentation

From: Nikolay Borisov <[email protected]>

should_send_event is no longer part of struct fsnotify_ops
so remove it

Signed-off-by: Nikolay Borisov <[email protected]>
---
include/linux/fsnotify_backend.h | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/include/linux/fsnotify_backend.h b/include/linux/fsnotify_backend.h
index 0f313f9..65a517d 100644
--- a/include/linux/fsnotify_backend.h
+++ b/include/linux/fsnotify_backend.h
@@ -84,8 +84,6 @@ struct fsnotify_fname;
* Each group much define these ops. The fsnotify infrastructure will call
* these operations for each relevant group.
*
- * should_send_event - given a group, inode, and mask this function determines
- * if the group is interested in this event.
* handle_event - main call for a group to handle an fs event
* free_group_priv - called when a group refcnt hits 0 to clean up the private union
* freeing_mark - called when a mark is being destroyed for some reason. The group
--
1.7.1


2015-06-01 16:10:00

by Jan Kara

[permalink] [raw]
Subject: Re: [PATCH] fsnotify: Remove obsolete documentation

On Mon 01-06-15 16:10:40, [email protected] wrote:
> From: Nikolay Borisov <[email protected]>
>
> should_send_event is no longer part of struct fsnotify_ops
> so remove it
>
> Signed-off-by: Nikolay Borisov <[email protected]>
Right. You can add:
Reviewed-by: Jan Kara <[email protected]>

Honza

> ---
> include/linux/fsnotify_backend.h | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/fsnotify_backend.h b/include/linux/fsnotify_backend.h
> index 0f313f9..65a517d 100644
> --- a/include/linux/fsnotify_backend.h
> +++ b/include/linux/fsnotify_backend.h
> @@ -84,8 +84,6 @@ struct fsnotify_fname;
> * Each group much define these ops. The fsnotify infrastructure will call
> * these operations for each relevant group.
> *
> - * should_send_event - given a group, inode, and mask this function determines
> - * if the group is interested in this event.
> * handle_event - main call for a group to handle an fs event
> * free_group_priv - called when a group refcnt hits 0 to clean up the private union
> * freeing_mark - called when a mark is being destroyed for some reason. The group
> --
> 1.7.1
>
--
Jan Kara <[email protected]>
SUSE Labs, CR