2015-06-01 18:46:08

by Toshi Kani

[permalink] [raw]
Subject: Re: [PATCH 4/4] x86/pat: Remove pat_enabled() checks

On Sun, 2015-05-31 at 11:48 +0200, Borislav Petkov wrote:
> From: Borislav Petkov <[email protected]>
>
> Now that we emulate a PAT table when PAT is disabled, there's no need
> for those checks anymore as the PAT abstraction will handle those cases
> too.
>
> Based on a conglomerate patch from Toshi Kani.
>
> Signed-off-by: Borislav Petkov <[email protected]>

I reviewed the 1/3-3/3 patchset in your "tip-mm-2" branch, which is
different from this submitted patchset 1/4-4/4. So, my review-by
applies to the 3 patches in the "tip-mm-2" branch.

Reviewed-by: Toshi Kani <[email protected]>

Thanks,
-Toshi


2015-06-01 18:51:32

by Borislav Petkov

[permalink] [raw]
Subject: Re: [PATCH 4/4] x86/pat: Remove pat_enabled() checks

On Mon, Jun 01, 2015 at 12:26:29PM -0600, Toshi Kani wrote:
> I reviewed the 1/3-3/3 patchset in your "tip-mm-2" branch, which is
> different from this submitted patchset 1/4-4/4. So, my review-by
> applies to the 3 patches in the "tip-mm-2" branch.

That's fine, the 4 patches were broken due to xen using
pat_init_cache_modes() too. So the 3 are the right ones.

Thanks.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--