2015-06-02 15:49:37

by Sergei Zviagintsev

Subject: [PATCH] kdbus: update kernel-doc for kdbus_sync_reply_wakeup()

kdbus_sync_reply_wakeup() doesn't remove reply object from connection
reply_list. Update function description.

Signed-off-by: Sergei Zviagintsev <[email protected]>
---
ipc/kdbus/reply.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ipc/kdbus/reply.c b/ipc/kdbus/reply.c
index 008dca801627..89d355b44f63 100644
--- a/ipc/kdbus/reply.c
+++ b/ipc/kdbus/reply.c
@@ -140,8 +140,7 @@ void kdbus_reply_unlink(struct kdbus_reply *r)
* @reply: The reply object
* @err: Error code to set on the remote side
*
- * Remove the synchronous reply object from its connection reply_list, and
- * wake up remote peer (method origin) with the appropriate synchronous reply
+ * Wake up remote peer (method origin) with the appropriate synchronous reply
* code.
*/
void kdbus_sync_reply_wakeup(struct kdbus_reply *reply, int err)
--
1.8.3.1

2015-06-03 10:29:10

by David Herrmann

Subject: Re: [PATCH] kdbus: update kernel-doc for kdbus_sync_reply_wakeup()

Hi

On Tue, Jun 2, 2015 at 5:48 PM, Sergei Zviagintsev <[email protected]> wrote:
> kdbus_sync_reply_wakeup() doesn't remove reply object from connection
> reply_list. Update function description.
>
> Signed-off-by: Sergei Zviagintsev <[email protected]>
> ---
> ipc/kdbus/reply.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: David Herrmann <[email protected]>

Thanks!
David

> diff --git a/ipc/kdbus/reply.c b/ipc/kdbus/reply.c
> index 008dca801627..89d355b44f63 100644
> --- a/ipc/kdbus/reply.c
> +++ b/ipc/kdbus/reply.c
> @@ -140,8 +140,7 @@ void kdbus_reply_unlink(struct kdbus_reply *r)
> * @reply: The reply object
> * @err: Error code to set on the remote side
> *
> - * Remove the synchronous reply object from its connection reply_list, and
> - * wake up remote peer (method origin) with the appropriate synchronous reply
> + * Wake up remote peer (method origin) with the appropriate synchronous reply
> * code.
> */
> void kdbus_sync_reply_wakeup(struct kdbus_reply *reply, int err)
> --
> 1.8.3.1
>

2015-06-04 06:00:08

by Greg Kroah-Hartman

Subject: Re: [PATCH] kdbus: update kernel-doc for kdbus_sync_reply_wakeup()

On Tue, Jun 02, 2015 at 06:48:47PM +0300, Sergei Zviagintsev wrote:
> kdbus_sync_reply_wakeup() doesn't remove reply object from connection
> reply_list. Update function description.
>
> Signed-off-by: Sergei Zviagintsev <[email protected]>
> Reviewed-by: David Herrmann <[email protected]>
> ---
> ipc/kdbus/reply.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Thanks for these, I've applied all 4 of them to the kdbus git repo.

greg k-h