2015-06-02 16:56:26

by Dan Streetman

[permalink] [raw]
Subject: [PATCH] MAINTAINERS: add zpool

Add entry for zpool to MAINTAINERS file.

Signed-off-by: Dan Streetman <[email protected]>
---
MAINTAINERS | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index e308718..5c0f13b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11056,6 +11056,13 @@ L: [email protected] (subscribers-only)
S: Maintained
F: drivers/net/wireless/zd1211rw/

+ZPOOL COMPRESSED PAGE STORAGE API
+M: Dan Streetman <[email protected]>
+L: [email protected]
+S: Maintained
+F: mm/zpool.c
+F: include/linux/zpool.h
+
ZR36067 VIDEO FOR LINUX DRIVER
L: [email protected]
L: [email protected]
--
2.1.0


2015-06-02 21:10:06

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: add zpool

On Tue, 2015-06-02 at 12:56 -0400, Dan Streetman wrote:
> Add entry for zpool to MAINTAINERS file.
[]
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -11056,6 +11056,13 @@ L: [email protected] (subscribers-only)
> S: Maintained
> F: drivers/net/wireless/zd1211rw/
>
> +ZPOOL COMPRESSED PAGE STORAGE API
> +M: Dan Streetman <[email protected]>
> +L: [email protected]
> +S: Maintained
> +F: mm/zpool.c
> +F: include/linux/zpool.h

If zpool.h is only included from files in mm/,
maybe zpool.h should be moved to mm/ ?

2015-06-02 21:20:15

by Dan Streetman

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: add zpool

On Tue, Jun 2, 2015 at 5:09 PM, Joe Perches <[email protected]> wrote:
> On Tue, 2015-06-02 at 12:56 -0400, Dan Streetman wrote:
>> Add entry for zpool to MAINTAINERS file.
> []
>> diff --git a/MAINTAINERS b/MAINTAINERS
> []
>> @@ -11056,6 +11056,13 @@ L: [email protected] (subscribers-only)
>> S: Maintained
>> F: drivers/net/wireless/zd1211rw/
>>
>> +ZPOOL COMPRESSED PAGE STORAGE API
>> +M: Dan Streetman <[email protected]>
>> +L: [email protected]
>> +S: Maintained
>> +F: mm/zpool.c
>> +F: include/linux/zpool.h
>
> If zpool.h is only included from files in mm/,
> maybe zpool.h should be moved to mm/ ?

It *could* be included by others, e.g. drivers/block/zram.

It currently is only used by zswap though, so yeah it could be moved
to mm/. Should I move it there, until (if ever) anyone outside of mm/
wants to use it?

>
>

2015-06-02 21:30:26

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: add zpool

On Tue, 2015-06-02 at 17:19 -0400, Dan Streetman wrote:
> On Tue, Jun 2, 2015 at 5:09 PM, Joe Perches <[email protected]> wrote:
> > On Tue, 2015-06-02 at 12:56 -0400, Dan Streetman wrote:
> >> Add entry for zpool to MAINTAINERS file.
> > []
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> > []
> >> @@ -11056,6 +11056,13 @@ L: [email protected] (subscribers-only)
> >> S: Maintained
> >> F: drivers/net/wireless/zd1211rw/
> >>
> >> +ZPOOL COMPRESSED PAGE STORAGE API
> >> +M: Dan Streetman <[email protected]>
> >> +L: [email protected]
> >> +S: Maintained
> >> +F: mm/zpool.c
> >> +F: include/linux/zpool.h
> >
> > If zpool.h is only included from files in mm/,
> > maybe zpool.h should be moved to mm/ ?
>
> It *could* be included by others, e.g. drivers/block/zram.
>
> It currently is only used by zswap though, so yeah it could be moved
> to mm/. Should I move it there, until (if ever) anyone outside of mm/
> wants to use it?

Up to you.

I think include/linux is a bit overstuffed and
whatever can be include local should be.

cheers, Joe

2015-06-03 03:55:46

by Sergey Senozhatsky

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: add zpool

On (06/02/15 14:30), Joe Perches wrote:
> > >> +ZPOOL COMPRESSED PAGE STORAGE API
> > >> +M: Dan Streetman <[email protected]>
> > >> +L: [email protected]
> > >> +S: Maintained
> > >> +F: mm/zpool.c
> > >> +F: include/linux/zpool.h
> > >
> > > If zpool.h is only included from files in mm/,
> > > maybe zpool.h should be moved to mm/ ?
> >
> > It *could* be included by others, e.g. drivers/block/zram.
> >
> > It currently is only used by zswap though, so yeah it could be moved
> > to mm/. Should I move it there, until (if ever) anyone outside of mm/
> > wants to use it?
>
> Up to you.
>
> I think include/linux is a bit overstuffed and
> whatever can be include local should be.
>

Hi,

I agree, can be local for now. if zram will ever want to use zpool
then we will move zpool.h to include/linux. just my 5 cents.

-ss

2015-06-03 12:55:46

by Dan Streetman

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: add zpool

On Tue, Jun 2, 2015 at 11:56 PM, Sergey Senozhatsky
<[email protected]> wrote:
> On (06/02/15 14:30), Joe Perches wrote:
>> > >> +ZPOOL COMPRESSED PAGE STORAGE API
>> > >> +M: Dan Streetman <[email protected]>
>> > >> +L: [email protected]
>> > >> +S: Maintained
>> > >> +F: mm/zpool.c
>> > >> +F: include/linux/zpool.h
>> > >
>> > > If zpool.h is only included from files in mm/,
>> > > maybe zpool.h should be moved to mm/ ?
>> >
>> > It *could* be included by others, e.g. drivers/block/zram.
>> >
>> > It currently is only used by zswap though, so yeah it could be moved
>> > to mm/. Should I move it there, until (if ever) anyone outside of mm/
>> > wants to use it?
>>
>> Up to you.
>>
>> I think include/linux is a bit overstuffed and
>> whatever can be include local should be.
>>
>
> Hi,
>
> I agree, can be local for now. if zram will ever want to use zpool
> then we will move zpool.h to include/linux. just my 5 cents.

Ok. I'll send a patch to move it from include/linux to mm/ and update
the drivers there that include it.


>
> -ss