2015-06-04 14:41:17

by Shailendra Verma

Subject: [PATCH] atm:he - Do not initialise statics to 0.

According to <stdbool.h> false is always '0' and
Static variables are initialised to 0 by GCC.

Signed-off-by: Shailendra Verma <[email protected]>
---
drivers/atm/he.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/atm/he.c b/drivers/atm/he.c
index 0237271..a8da3a5 100644
--- a/drivers/atm/he.c
+++ b/drivers/atm/he.c
@@ -117,7 +117,7 @@ static short nvpibits = -1;
static short nvcibits = -1;
static short rx_skb_reserve = 16;
static bool irq_coalesce = true;
-static bool sdh = 0;
+static bool sdh;

/* Read from EEPROM = 0000 0011b */
static unsigned int readtab[] = {
--
1.9.1

2015-06-04 22:43:30

by David Miller

Subject: Re: [PATCH] atm:he - Do not initialise statics to 0.

From: Shailendra Verma <[email protected]>
Date: Thu, 4 Jun 2015 20:11:00 +0530

> According to <stdbool.h> false is always '0' and
> Static variables are initialised to 0 by GCC.
>
> Signed-off-by: Shailendra Verma <[email protected]>

Applied, thanks.