2015-04-14 16:44:43

by Matwey V. Kornilov

Subject: [PATCH] uio: pruss: Drop depends on ARCH_DAVINCI_DA850 from config

mach-dependent stuff has been removed by
2eb2478d471e45e1d0c8bb3defbf82bf7204e13d
So, there is no need to keep
depends on ARCH_DAVINCI_DA850

Signed-off-by: Matwey V. Kornilov <[email protected]>
---
drivers/uio/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/uio/Kconfig b/drivers/uio/Kconfig
index 8a15c32..9c9178a 100644
--- a/drivers/uio/Kconfig
+++ b/drivers/uio/Kconfig
@@ -126,7 +126,6 @@ config UIO_FSL_ELBC_GPCM_NETX5152

config UIO_PRUSS
tristate "Texas Instruments PRUSS driver"
- depends on ARCH_DAVINCI_DA850
select GENERIC_ALLOCATOR
help
PRUSS driver for OMAPL138/DA850/AM18XX devices
--
2.1.4

2015-04-15 05:28:35

by TK, Pratheesh Gangadhar

Subject: RE: [PATCH] uio: pruss: Drop depends on ARCH_DAVINCI_DA850 from config

> From: Matwey V. Kornilov [mailto:[email protected]]

> mach-dependent stuff has been removed by
> 2eb2478d471e45e1d0c8bb3defbf82bf7204e13d
> So, there is no need to keep
> depends on ARCH_DAVINCI_DA850
>
> Signed-off-by: Matwey V. Kornilov <[email protected]>
> ---
> drivers/uio/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/uio/Kconfig b/drivers/uio/Kconfig index 8a15c32..9c9178a
> 100644
> --- a/drivers/uio/Kconfig
> +++ b/drivers/uio/Kconfig
> @@ -126,7 +126,6 @@ config UIO_FSL_ELBC_GPCM_NETX5152
>
> config UIO_PRUSS
> tristate "Texas Instruments PRUSS driver"
> - depends on ARCH_DAVINCI_DA850
> select GENERIC_ALLOCATOR
> help
> PRUSS driver for OMAPL138/DA850/AM18XX devices

Acked-by: Pratheesh Gangadhar <[email protected]>

2015-05-24 18:54:57

by Greg Kroah-Hartman

Subject: Re: [PATCH] uio: pruss: Drop depends on ARCH_DAVINCI_DA850 from config

On Tue, Apr 14, 2015 at 07:44:10PM +0300, Matwey V. Kornilov wrote:
> mach-dependent stuff has been removed by
> 2eb2478d471e45e1d0c8bb3defbf82bf7204e13d
> So, there is no need to keep
> depends on ARCH_DAVINCI_DA850
>
> Signed-off-by: Matwey V. Kornilov <[email protected]>
> Acked-by: Pratheesh Gangadhar <[email protected]>
> ---
> drivers/uio/Kconfig | 1 -
> 1 file changed, 1 deletion(-)

This patch breaks the build on x86-64, please be more careful when
sending untested patches.

greg k-h

2015-06-06 15:50:17

by Matwey V. Kornilov

Subject: [PATCHv2 1/2] uio: pruss: Include <linux/sizes.h>

uio_pruss references SZ_16K and SZ_256K defines, but linux/sizes.h is not included.

Signed-off-by: Matwey V. Kornilov <[email protected]>
---
Changes from v1:
- Add uio: pruss: Include <linux/sizes.h> patch to allow build on all architectures

drivers/uio/uio_pruss.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/uio/uio_pruss.c b/drivers/uio/uio_pruss.c
index 818735b..ca9e2fa 100644
--- a/drivers/uio/uio_pruss.c
+++ b/drivers/uio/uio_pruss.c
@@ -24,6 +24,7 @@
#include <linux/io.h>
#include <linux/clk.h>
#include <linux/dma-mapping.h>
+#include <linux/sizes.h>
#include <linux/slab.h>
#include <linux/genalloc.h>

--
2.1.4

2015-06-06 15:50:32

by Matwey V. Kornilov

Subject: [PATCHv2 2/2] uio: pruss: Drop depends on ARCH_DAVINCI_DA850 from config

mach-dependant stuff has been removed by
2eb2478d471e45e1d0c8bb3defbf82bf7204e13d

There is no need to keep
depends on ARCH_DAVINCI_DA850

Signed-off-by: Matwey V. Kornilov <[email protected]>
---
drivers/uio/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/uio/Kconfig b/drivers/uio/Kconfig
index 8a15c32..9c9178a 100644
--- a/drivers/uio/Kconfig
+++ b/drivers/uio/Kconfig
@@ -126,7 +126,6 @@ config UIO_FSL_ELBC_GPCM_NETX5152

config UIO_PRUSS
tristate "Texas Instruments PRUSS driver"
- depends on ARCH_DAVINCI_DA850
select GENERIC_ALLOCATOR
help
PRUSS driver for OMAPL138/DA850/AM18XX devices
--
2.1.4

2015-06-06 16:11:23

by Richard Weinberger

Subject: Re: [PATCHv2 2/2] uio: pruss: Drop depends on ARCH_DAVINCI_DA850 from config

On Sat, Jun 6, 2015 at 5:49 PM, Matwey V. Kornilov <[email protected]> wrote:
> mach-dependant stuff has been removed by
> 2eb2478d471e45e1d0c8bb3defbf82bf7204e13d
>
> There is no need to keep
> depends on ARCH_DAVINCI_DA850

The driver dependencies are still broken.
It needs ioremap(), hence make it depend on HAS_IOMEM.
Otherwise you break the build for UML and some s390 variants
which do not have io memory.

--
Thanks,
//richard

2015-06-06 16:13:40

by Matwey V. Kornilov

Subject: Re: [PATCHv2 2/2] uio: pruss: Drop depends on ARCH_DAVINCI_DA850 from config

2015-06-06 19:11 GMT+03:00 Richard Weinberger <[email protected]>:
> On Sat, Jun 6, 2015 at 5:49 PM, Matwey V. Kornilov <[email protected]> wrote:
>> mach-dependant stuff has been removed by
>> 2eb2478d471e45e1d0c8bb3defbf82bf7204e13d
>>
>> There is no need to keep
>> depends on ARCH_DAVINCI_DA850
>
> The driver dependencies are still broken.
> It needs ioremap(), hence make it depend on HAS_IOMEM.
> Otherwise you break the build for UML and some s390 variants
> which do not have io memory.

Thank you, I will go redo.

>
> --
> Thanks,
> //richard
>



--
With best regards,
Matwey V. Kornilov.
Sternberg Astronomical Institute, Lomonosov Moscow State University, Russia