2015-06-07 09:01:35

by Maxime Coquelin

Subject: [PATCH] clockevents/drivers/timer-stm32: Fix build error spotted by kbuild test robot

This patch fixes below error spotted by kbuild test robot when building
with ARCH=ia64:

All error/warnings (new ones prefixed by >>):

drivers/clocksource/timer-stm32.c:38:28: error: field 'evtdev' has incomplete type

struct clock_event_device evtdev;
^

drivers/clocksource/timer-stm32.c:44:19: warning: 'enum clock_event_mode' declared inside parameter list

struct clock_event_device *evtdev)

The fix consists in making the STM32 timer depend on GENERIC_CLOCKEVENTS.

Reported-by: kbuild test robot <[email protected]>
Signed-off-by: Maxime Coquelin <[email protected]>
---
drivers/clocksource/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index bec25b3..1778c90 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -113,7 +113,7 @@ config CLKSRC_LPC32XX

config CLKSRC_STM32
bool "Clocksource for STM32 SoCs" if COMPILE_TEST
- depends on OF
+ depends on OF && GENERIC_CLOCKEVENTS
select CLKSRC_MMIO

config ARM_ARCH_TIMER
--
1.9.1

2015-06-08 17:39:12

by Daniel Lezcano

Subject: Re: [PATCH] clockevents/drivers/timer-stm32: Fix build error spotted by kbuild test robot

On 06/07/2015 11:01 AM, Maxime Coquelin wrote:
> This patch fixes below error spotted by kbuild test robot when building
> with ARCH=ia64:
>
> All error/warnings (new ones prefixed by >>):
>
> drivers/clocksource/timer-stm32.c:38:28: error: field 'evtdev' has incomplete type
>
> struct clock_event_device evtdev;
> ^
>
> drivers/clocksource/timer-stm32.c:44:19: warning: 'enum clock_event_mode' declared inside parameter list
>
> struct clock_event_device *evtdev)
>
> The fix consists in making the STM32 timer depend on GENERIC_CLOCKEVENTS.
>
> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: Maxime Coquelin <[email protected]>

Sounds good.

Thomas, Ingo ? do you will take this patch directly ? Or do you prefer I
queue it and waiting for more fixes to come before sending a PR ?

Thanks
-- Daniel

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

2015-06-08 20:08:20

by Thomas Gleixner

Subject: Re: [PATCH] clockevents/drivers/timer-stm32: Fix build error spotted by kbuild test robot

On Mon, 8 Jun 2015, Daniel Lezcano wrote:

> Or do you prefer I queue it and waiting for more fixes to come
> before sending a PR ?

Yes please.

2015-06-08 20:48:00

by Daniel Lezcano

Subject: Re: [PATCH] clockevents/drivers/timer-stm32: Fix build error spotted by kbuild test robot

On 06/08/2015 10:08 PM, Thomas Gleixner wrote:
> On Mon, 8 Jun 2015, Daniel Lezcano wrote:
>
>> Or do you prefer I queue it and waiting for more fixes to come
>> before sending a PR ?
>
> Yes please.

Ok, thanks.

-- Daniel


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog