2015-06-08 07:41:51

by Alexandre Courbot

Subject: [PATCH] ARM: tegra: roth: Add MMC pwrseq to power wifi on

The wifi chip on roth needs to have its reset deasserted in order to be
probed. Add a mmc-pwrseq-simple to allow this to happen and get wifi
working at boot time.

Signed-off-by: Alexandre Courbot <[email protected]>
---
arch/arm/boot/dts/tegra114-roth.dts | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/tegra114-roth.dts b/arch/arm/boot/dts/tegra114-roth.dts
index ea1772a686c2..04762532a178 100644
--- a/arch/arm/boot/dts/tegra114-roth.dts
+++ b/arch/arm/boot/dts/tegra114-roth.dts
@@ -972,6 +972,11 @@
nvidia,invert-interrupt;
};

+ sdhci0_pwrseq: sdhci0_pwrseq {
+ compatible = "mmc-pwrseq-simple";
+ reset-gpios = <&gpio TEGRA_GPIO(CC, 5) GPIO_ACTIVE_LOW>;
+ };
+
/* Wifi */
sdhci@78000000 {
status = "okay";
@@ -979,6 +984,7 @@
broken-cd;
keep-power-in-suspend;
cap-sdio-irq;
+ mmc-pwrseq = <&sdhci0_pwrseq>;
};

/* SD card */
--
2.4.2

2015-06-08 08:12:20

by Javier Martinez Canillas

Subject: Re: [PATCH] ARM: tegra: roth: Add MMC pwrseq to power wifi on

Hello Alexandre,

On Mon, Jun 8, 2015 at 9:41 AM, Alexandre Courbot <[email protected]> wrote:
> The wifi chip on roth needs to have its reset deasserted in order to be
> probed. Add a mmc-pwrseq-simple to allow this to happen and get wifi
> working at boot time.
>
> Signed-off-by: Alexandre Courbot <[email protected]>
> ---
> arch/arm/boot/dts/tegra114-roth.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/tegra114-roth.dts b/arch/arm/boot/dts/tegra114-roth.dts
> index ea1772a686c2..04762532a178 100644
> --- a/arch/arm/boot/dts/tegra114-roth.dts
> +++ b/arch/arm/boot/dts/tegra114-roth.dts
> @@ -972,6 +972,11 @@
> nvidia,invert-interrupt;
> };
>
> + sdhci0_pwrseq: sdhci0_pwrseq {
> + compatible = "mmc-pwrseq-simple";
> + reset-gpios = <&gpio TEGRA_GPIO(CC, 5) GPIO_ACTIVE_LOW>;
> + };
> +
> /* Wifi */
> sdhci@78000000 {
> status = "okay";
> @@ -979,6 +984,7 @@
> broken-cd;
> keep-power-in-suspend;
> cap-sdio-irq;
> + mmc-pwrseq = <&sdhci0_pwrseq>;
> };
>
> /* SD card */

I'm neither familiar with this board nor have a schematic but the
patch looks good to me.

Reviewed-by: Javier Martinez Canillas <[email protected]>

Best regards,
Javier

2015-07-08 07:19:18

by Alexandre Courbot

Subject: Re: [PATCH] ARM: tegra: roth: Add MMC pwrseq to power wifi on

Ping Thierry, is this patch good to be merged?

On Mon, Jun 8, 2015 at 5:12 PM, Javier Martinez Canillas
<[email protected]> wrote:
> Hello Alexandre,
>
> On Mon, Jun 8, 2015 at 9:41 AM, Alexandre Courbot <[email protected]> wrote:
>> The wifi chip on roth needs to have its reset deasserted in order to be
>> probed. Add a mmc-pwrseq-simple to allow this to happen and get wifi
>> working at boot time.
>>
>> Signed-off-by: Alexandre Courbot <[email protected]>
>> ---
>> arch/arm/boot/dts/tegra114-roth.dts | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/tegra114-roth.dts b/arch/arm/boot/dts/tegra114-roth.dts
>> index ea1772a686c2..04762532a178 100644
>> --- a/arch/arm/boot/dts/tegra114-roth.dts
>> +++ b/arch/arm/boot/dts/tegra114-roth.dts
>> @@ -972,6 +972,11 @@
>> nvidia,invert-interrupt;
>> };
>>
>> + sdhci0_pwrseq: sdhci0_pwrseq {
>> + compatible = "mmc-pwrseq-simple";
>> + reset-gpios = <&gpio TEGRA_GPIO(CC, 5) GPIO_ACTIVE_LOW>;
>> + };
>> +
>> /* Wifi */
>> sdhci@78000000 {
>> status = "okay";
>> @@ -979,6 +984,7 @@
>> broken-cd;
>> keep-power-in-suspend;
>> cap-sdio-irq;
>> + mmc-pwrseq = <&sdhci0_pwrseq>;
>> };
>>
>> /* SD card */
>
> I'm neither familiar with this board nor have a schematic but the
> patch looks good to me.
>
> Reviewed-by: Javier Martinez Canillas <[email protected]>
>
> Best regards,
> Javier