2015-06-09 15:10:26

by Matwey V. Kornilov

Subject: [PATCH v3 1/4] uio: pruss: Include <linux/sizes.h>

uio_pruss references SZ_16K and SZ_256K defines, but linux/sizes.h is not included.

Signed-off-by: Matwey V. Kornilov <[email protected]>
Changes from v1:
- Fix build for platforms without ioremap
- Fix build for x86_64
---
drivers/uio/uio_pruss.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/uio/uio_pruss.c b/drivers/uio/uio_pruss.c
index 818735b..ca9e2fa 100644
--- a/drivers/uio/uio_pruss.c
+++ b/drivers/uio/uio_pruss.c
@@ -24,6 +24,7 @@
#include <linux/io.h>
#include <linux/clk.h>
#include <linux/dma-mapping.h>
+#include <linux/sizes.h>
#include <linux/slab.h>
#include <linux/genalloc.h>

--
2.1.4

2015-06-09 15:11:07

by Matwey V. Kornilov

Subject: [PATCH v3 2/4] uio: pruss: Include <linux/vmalloc.h>

uio_pruss uses ioremap which is in linux/vmalloc.h according to LDD3 sec. 8.3

Signed-off-by: Matwey V. Kornilov <[email protected]>
---
drivers/uio/uio_pruss.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/uio/uio_pruss.c b/drivers/uio/uio_pruss.c
index ca9e2fa..5ae7c31 100644
--- a/drivers/uio/uio_pruss.c
+++ b/drivers/uio/uio_pruss.c
@@ -27,6 +27,7 @@
#include <linux/sizes.h>
#include <linux/slab.h>
#include <linux/genalloc.h>
+#include <linux/vmalloc.h>

#define DRV_NAME "pruss_uio"
#define DRV_VERSION "1.0"
--
2.1.4

2015-06-09 15:10:36

by Matwey V. Kornilov

Subject: [PATCH v3 3/4] uio: pruss: Add CONFIG_HAS_IOMEM dependence

uio_pruss uses io memory, that should be explicitly depend on it

Signed-off-by: Matwey V. Kornilov <[email protected]>
---
drivers/uio/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/uio/Kconfig b/drivers/uio/Kconfig
index 8a15c32..91d9f2b 100644
--- a/drivers/uio/Kconfig
+++ b/drivers/uio/Kconfig
@@ -128,6 +128,7 @@ config UIO_PRUSS
tristate "Texas Instruments PRUSS driver"
depends on ARCH_DAVINCI_DA850
select GENERIC_ALLOCATOR
+ depends on HAS_IOMEM
help
PRUSS driver for OMAPL138/DA850/AM18XX devices
PRUSS driver requires user space components, examples and user space
--
2.1.4

2015-06-09 15:10:56

by Matwey V. Kornilov

Subject: [PATCH v3 4/4] uio: pruss: Drop depends on ARCH_DAVINCI_DA850 from config

mach-dependant stuff has been removed by
2eb2478d471e45e1d0c8bb3defbf82bf7204e13d

There is no need to keep
depends on ARCH_DAVINCI_DA850

Signed-off-by: Matwey V. Kornilov <[email protected]>
---
drivers/uio/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/uio/Kconfig b/drivers/uio/Kconfig
index 91d9f2b..48fb1d9 100644
--- a/drivers/uio/Kconfig
+++ b/drivers/uio/Kconfig
@@ -126,7 +126,6 @@ config UIO_FSL_ELBC_GPCM_NETX5152

config UIO_PRUSS
tristate "Texas Instruments PRUSS driver"
- depends on ARCH_DAVINCI_DA850
select GENERIC_ALLOCATOR
depends on HAS_IOMEM
help
--
2.1.4

2015-06-09 15:35:42

by Greg Kroah-Hartman

Subject: Re: [PATCH v3 4/4] uio: pruss: Drop depends on ARCH_DAVINCI_DA850 from config

On Tue, Jun 09, 2015 at 06:09:45PM +0300, Matwey V. Kornilov wrote:
> mach-dependant stuff has been removed by
> 2eb2478d471e45e1d0c8bb3defbf82bf7204e13d

Please spell out what that commit id is with the text afterward, much
like the rest of the changelog entries that reference a git id does:
2eb2478d471e ("uio: uio_pruss: replace private SRAM API with genalloc")

thanks,

greg k-h

2015-06-09 15:36:23

by Greg Kroah-Hartman

Subject: Re: [PATCH v3 2/4] uio: pruss: Include <linux/vmalloc.h>

On Tue, Jun 09, 2015 at 06:09:43PM +0300, Matwey V. Kornilov wrote:
> uio_pruss uses ioremap which is in linux/vmalloc.h according to LDD3 sec. 8.3

You are referencing a 10-year-old book, is it still relevant here? Are
you seeing build failures without this?

thanks,

greg k-h

2015-06-09 15:36:50

by Greg Kroah-Hartman

Subject: Re: [PATCH v3 1/4] uio: pruss: Include <linux/sizes.h>

On Tue, Jun 09, 2015 at 06:09:42PM +0300, Matwey V. Kornilov wrote:
> uio_pruss references SZ_16K and SZ_256K defines, but linux/sizes.h is not included.
>
> Signed-off-by: Matwey V. Kornilov <[email protected]>
> Changes from v1:
> - Fix build for platforms without ioremap
> - Fix build for x86_64

Changes go below the --- line, not above it, we don't want to see them
in the changelog.

thanks,

greg k-h