2015-06-10 08:11:41

by Wang Long

Subject: [PATCH] ring-buffer-benchmark: Fix the wrong param in module_param

The {producer|consumer}_{nice|fifo} parameters are integer
type, we should use 'int' as the second param in module_param.

For example(consumer_fifo):
the default value of consumer_fifo is -1.
Without this patch:
# cat /sys/module/ring_buffer_benchmark/parameters/consumer_fifo
4294967295
With this patch:
# cat /sys/module/ring_buffer_benchmark/parameters/consumer_fifo
-1

Signed-off-by: Wang Long <[email protected]>
---
kernel/trace/ring_buffer_benchmark.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/trace/ring_buffer_benchmark.c b/kernel/trace/ring_buffer_benchmark.c
index e1b4a81..61b933b 100644
--- a/kernel/trace/ring_buffer_benchmark.c
+++ b/kernel/trace/ring_buffer_benchmark.c
@@ -46,16 +46,16 @@ static int consumer_nice = MAX_NICE;
static int producer_fifo = -1;
static int consumer_fifo = -1;

-module_param(producer_nice, uint, 0644);
+module_param(producer_nice, int, 0644);
MODULE_PARM_DESC(producer_nice, "nice prio for producer");

-module_param(consumer_nice, uint, 0644);
+module_param(consumer_nice, int, 0644);
MODULE_PARM_DESC(consumer_nice, "nice prio for consumer");

-module_param(producer_fifo, uint, 0644);
+module_param(producer_fifo, int, 0644);
MODULE_PARM_DESC(producer_fifo, "fifo prio for producer");

-module_param(consumer_fifo, uint, 0644);
+module_param(consumer_fifo, int, 0644);
MODULE_PARM_DESC(consumer_fifo, "fifo prio for consumer");

static int read_events;
--
1.8.3.4

2015-06-10 19:44:59

by Steven Rostedt

Subject: Re: [PATCH] ring-buffer-benchmark: Fix the wrong param in module_param

On Wed, 10 Jun 2015 08:11:13 +0000
Wang Long <[email protected]> wrote:

> The {producer|consumer}_{nice|fifo} parameters are integer
> type, we should use 'int' as the second param in module_param.
>
> For example(consumer_fifo):
> the default value of consumer_fifo is -1.
> Without this patch:
> # cat /sys/module/ring_buffer_benchmark/parameters/consumer_fifo
> 4294967295
> With this patch:
> # cat /sys/module/ring_buffer_benchmark/parameters/consumer_fifo
> -1
>
> Signed-off-by: Wang Long <[email protected]>
> ---

Thanks, Applied!

-- Steve