2015-06-10 08:12:33

by Wang Long

Subject: [PATCH] ring-buffer-benchmark: Fix the wrong type

The macro 'module_param' shows that the type of the
variable disable_reader and write_iteration is unsigned
integer. so, we change their type form int to unsigned int.

Signed-off-by: Wang Long <[email protected]>
---
kernel/trace/ring_buffer_benchmark.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/ring_buffer_benchmark.c b/kernel/trace/ring_buffer_benchmark.c
index 1b28df2..e1b4a81 100644
--- a/kernel/trace/ring_buffer_benchmark.c
+++ b/kernel/trace/ring_buffer_benchmark.c
@@ -32,11 +32,11 @@ static struct task_struct *producer;
static struct task_struct *consumer;
static unsigned long read;

-static int disable_reader;
+static unsigned int disable_reader;
module_param(disable_reader, uint, 0644);
MODULE_PARM_DESC(disable_reader, "only run producer");

-static int write_iteration = 50;
+static unsigned int write_iteration = 50;
module_param(write_iteration, uint, 0644);
MODULE_PARM_DESC(write_iteration, "# of writes between timestamp readings");

--
1.8.3.4

2015-06-10 19:45:43

by Steven Rostedt

Subject: Re: [PATCH] ring-buffer-benchmark: Fix the wrong type

On Wed, 10 Jun 2015 08:12:07 +0000
Wang Long <[email protected]> wrote:

> The macro 'module_param' shows that the type of the
> variable disable_reader and write_iteration is unsigned
> integer. so, we change their type form int to unsigned int.
>
> Signed-off-by: Wang Long <[email protected]>

Thanks, applied!

-- Steve