2015-06-10 08:13:03

by Wang Long

[permalink] [raw]
Subject: [PATCH] ring-buffer-benchmark: Fix the wrong sched_priority of producer

The producer should be used producer_fifo as its sched_priority,
so correct it.

Signed-off-by: Wang Long <[email protected]>
---
kernel/trace/ring_buffer_benchmark.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/ring_buffer_benchmark.c b/kernel/trace/ring_buffer_benchmark.c
index 13d945c..1b28df2 100644
--- a/kernel/trace/ring_buffer_benchmark.c
+++ b/kernel/trace/ring_buffer_benchmark.c
@@ -450,7 +450,7 @@ static int __init ring_buffer_benchmark_init(void)

if (producer_fifo >= 0) {
struct sched_param param = {
- .sched_priority = consumer_fifo
+ .sched_priority = producer_fifo
};
sched_setscheduler(producer, SCHED_FIFO, &param);
} else
--
1.8.3.4


2015-06-10 19:47:13

by Steven Rostedt

[permalink] [raw]
Subject: Re: [PATCH] ring-buffer-benchmark: Fix the wrong sched_priority of producer

On Wed, 10 Jun 2015 08:12:37 +0000
Wang Long <[email protected]> wrote:

> The producer should be used producer_fifo as its sched_priority,
> so correct it.
>
> Signed-off-by: Wang Long <[email protected]>

I also add this for stable 2.6.33+

Thanks, applied.

-- Steve

> ---
> kernel/trace/ring_buffer_benchmark.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/ring_buffer_benchmark.c b/kernel/trace/ring_buffer_benchmark.c
> index 13d945c..1b28df2 100644
> --- a/kernel/trace/ring_buffer_benchmark.c
> +++ b/kernel/trace/ring_buffer_benchmark.c
> @@ -450,7 +450,7 @@ static int __init ring_buffer_benchmark_init(void)
>
> if (producer_fifo >= 0) {
> struct sched_param param = {
> - .sched_priority = consumer_fifo
> + .sched_priority = producer_fifo
> };
> sched_setscheduler(producer, SCHED_FIFO, &param);
> } else