2015-06-13 12:19:59

by Mathias Krause

[permalink] [raw]
Subject: [PATCH] ipmi: constify ACPI device ids

Constify the ACPI device ID array, it doesn't need to be writable at
runtime.

Signed-off-by: Mathias Krause <[email protected]>
---
drivers/char/ipmi/ipmi_ssif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
index 207689c444a8..95a0910d91e4 100644
--- a/drivers/char/ipmi/ipmi_ssif.c
+++ b/drivers/char/ipmi/ipmi_ssif.c
@@ -1787,7 +1787,7 @@ skip_addr:
}

#ifdef CONFIG_ACPI
-static struct acpi_device_id ssif_acpi_match[] = {
+static const struct acpi_device_id ssif_acpi_match[] = {
{ "IPI0001", 0 },
{ },
};
--
1.7.10.4


2015-06-13 16:26:35

by Corey Minyard

[permalink] [raw]
Subject: Re: [PATCH] ipmi: constify ACPI device ids

Queued for the next kernel release. Thanks.

-corey

On 06/13/2015 07:19 AM, Mathias Krause wrote:
> Constify the ACPI device ID array, it doesn't need to be writable at
> runtime.
>
> Signed-off-by: Mathias Krause <[email protected]>
> ---
> drivers/char/ipmi/ipmi_ssif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
> index 207689c444a8..95a0910d91e4 100644
> --- a/drivers/char/ipmi/ipmi_ssif.c
> +++ b/drivers/char/ipmi/ipmi_ssif.c
> @@ -1787,7 +1787,7 @@ skip_addr:
> }
>
> #ifdef CONFIG_ACPI
> -static struct acpi_device_id ssif_acpi_match[] = {
> +static const struct acpi_device_id ssif_acpi_match[] = {
> { "IPI0001", 0 },
> { },
> };